Skip to content

Conversation

@SteveMacenski
Copy link
Member

@SteveMacenski SteveMacenski commented Jun 26, 2025

Requires documentation ros-navigation/docs.nav2.org#716

Requires testing by @dw25628

Closes #5296

Generated with Claude Code Sonnet 4

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
nav2_costmap_2d/src/clear_costmap_service.cpp 17.64% 14 Missing ⚠️
Files with missing lines Coverage Δ
...vior_tree/plugins/action/clear_costmap_service.hpp 100.00% <100.00%> (ø)
...vior_tree/plugins/action/clear_costmap_service.cpp 100.00% <100.00%> (ø)
nav2_costmap_2d/src/clear_costmap_service.cpp 35.82% <17.64%> (-6.18%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dw25628
Copy link

dw25628 commented Jun 27, 2025

@SteveMacenski I tested this morning and this works as intended. Apologies for not getting my PR up faster, I was trying to build out better test coverage for the clear costmap services. If you can allow me rights to push to this PR I can push up my addition for costmap clearing unit tests in nav2_costmap_2d. I was hoping to get a more full coverage integration test completed but have not gotten that done yet.

I also have migration documentation updates I can add to ros-navigation/docs.nav2.org#716 if I am granted access.

Any possibility we can backport these changes to Jazzy?

Thanks for all you do

@SteveMacenski
Copy link
Member Author

No worries on the delay - I honestly didn't think the AI would get this one (most of my multi-file refactors it really doesn't do well; this was a smaller one that I was pushing the edge to see if it would work as an experiment). I was mostly just toying around with the new tools.

I was trying to build out better test coverage for the clear costmap services. If you can allow me rights to push to this PR I can push up my addition for costmap clearing unit tests in nav2_costmap_2d

Can you open it up instead as a separate PR? Its easier for us to do that than for me to give you access to the core repo or try to figure out permissions for just this branch. Ditto with the migration guide doc!

If it fixes the issue, I can merge and wait on your PR for more tests 😄

Any possibility we can backport these changes to Jazzy?

I can try an autobackport on merge. If it doesn't work, it would need to be manually cherry picked and have the conflicts resolved

@SteveMacenski SteveMacenski merged commit c0bf67e into main Jun 27, 2025
14 of 15 checks passed
@SteveMacenski SteveMacenski deleted the clear_costmap_around_pose branch June 27, 2025 17:46
mergify bot pushed a commit that referenced this pull request Jun 27, 2025
* Adding clear costmap around pose impl

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_msgs/srv/ClearCostmapAroundPose.srv

Signed-off-by: Steve Macenski <[email protected]>

* Adding APIs for simple commander

Signed-off-by: Steve Macenski <[email protected]>

* linting

Signed-off-by: Steve Macenski <[email protected]>

* adding import

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
(cherry picked from commit c0bf67e)

# Conflicts:
#	nav2_costmap_2d/include/nav2_costmap_2d/clear_costmap_service.hpp
#	nav2_msgs/srv/__init__.py
#	nav2_simple_commander/nav2_simple_commander/robot_navigator.py
mergify bot pushed a commit that referenced this pull request Jun 27, 2025
* Adding clear costmap around pose impl

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_msgs/srv/ClearCostmapAroundPose.srv

Signed-off-by: Steve Macenski <[email protected]>

* Adding APIs for simple commander

Signed-off-by: Steve Macenski <[email protected]>

* linting

Signed-off-by: Steve Macenski <[email protected]>

* adding import

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
(cherry picked from commit c0bf67e)

# Conflicts:
#	nav2_costmap_2d/include/nav2_costmap_2d/clear_costmap_service.hpp
#	nav2_costmap_2d/src/clear_costmap_service.cpp
#	nav2_simple_commander/nav2_simple_commander/robot_navigator.py
@SteveMacenski
Copy link
Member Author

@dw25628 this isn't able to be autobackported. Please open a cherry-picked PR for Jazzy :-)

dw25628 pushed a commit to dw25628/navigation2 that referenced this pull request Jun 30, 2025
SteveMacenski added a commit that referenced this pull request Jun 30, 2025
* Adding clear costmap around pose service option (#5309)

(cherry picked from commit c0bf67e
Signed-off-by: dw25628 <[email protected]>

* Linting

Signed-off-by: dw25628 <[email protected]>

* Removed __init__.py that came in with cherry pick

Signed-off-by: dw25628 <[email protected]>

---------

Signed-off-by: dw25628 <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
OmarRebai pushed a commit to OmarRebai/navigation2 that referenced this pull request Jul 2, 2025
* Adding clear costmap around pose impl

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_msgs/srv/ClearCostmapAroundPose.srv

Signed-off-by: Steve Macenski <[email protected]>

* Adding APIs for simple commander

Signed-off-by: Steve Macenski <[email protected]>

* linting

Signed-off-by: Steve Macenski <[email protected]>

* adding import

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>
SakshayMahna pushed a commit to SakshayMahna/navigation2 that referenced this pull request Jul 6, 2025
* Adding clear costmap around pose impl

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_msgs/srv/ClearCostmapAroundPose.srv

Signed-off-by: Steve Macenski <[email protected]>

* Adding APIs for simple commander

Signed-off-by: Steve Macenski <[email protected]>

* linting

Signed-off-by: Steve Macenski <[email protected]>

* adding import

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
SteveMacenski added a commit that referenced this pull request Jul 17, 2025
#5300)

* fix: Add PushRosNamespace action to navigation launch file and update comments for parameter namespacing

Signed-off-by: orebai <[email protected]>

* fix: Reorder import statements in navigation launch file for consistency

Signed-off-by: orebai <[email protected]>

* fix: Correct formatting of comments in navigation launch file for clarity

Signed-off-by: orebai <[email protected]>

* fix: Add PushRosNamespace action to multiple launch files for parameter namespacing

Signed-off-by: orebai <[email protected]>

* fix: Add PushRosNamespace action to slam_launch.py for parameter namespacing

Signed-off-by: orebai <[email protected]>

* Adding logging for matched events and dropped messages into pub/sub of new nav2_ros_common package. Also adding QoS overrides default ON (#5302)

* Adding logging for matched events and dropped messages

Signed-off-by: Steve Macenski <[email protected]>

* toggle on

Signed-off-by: Steve Macenski <[email protected]>

* apply for smac 2D

Signed-off-by: Steve Macenski <[email protected]>

* Update interface_factories.hpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>

* Add LaunchConfigAsBool (Fixes #5233) (#5301)

* Add LaunchConfigAsBool (Fixes #5233)

Signed-off-by: nishalangovender <[email protected]>

* Fix Linting

Signed-off-by: nishalangovender <[email protected]>

* Fix ament_mypy and pre-commit

Signed-off-by: nishalangovender <[email protected]>

* Added Type Annotations

Signed-off-by: Nishalan Govender <[email protected]>

* mypy ignore

Signed-off-by: Nishalan Govender <[email protected]>

* launch.Substitution

Signed-off-by: Nishalan Govender <[email protected]>

* Update All Bools in nav2_bringup

Signed-off-by: Nishalan Govender <[email protected]>

---------

Signed-off-by: nishalangovender <[email protected]>
Signed-off-by: Nishalan Govender <[email protected]>
Signed-off-by: orebai <[email protected]>

* Create claude.yml

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>

* Update claude.yml

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>

* Update claude.yml

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>

* Update claude.yml for authorized users

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>

* Update claude.yml

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>

* Update claude.yml

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>

* Adding clear costmap around pose service option (#5309)

* Adding clear costmap around pose impl

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_msgs/srv/ClearCostmapAroundPose.srv

Signed-off-by: Steve Macenski <[email protected]>

* Adding APIs for simple commander

Signed-off-by: Steve Macenski <[email protected]>

* linting

Signed-off-by: Steve Macenski <[email protected]>

* adding import

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: orebai <[email protected]>

* Add support for enable_lifecycle_services parameter in LifecycleNode (#5307)

Expose the enable_communication_interface parameter from rclcpp_lifecycle::LifecycleNode
through nav2's LifecycleNode wrapper. This allows users to disable lifecycle communication
interfaces when manually managing node lifecycle transitions.

The parameter can be set via NodeOptions parameter overrides:
```cpp
rclcpp::NodeOptions options;
options.parameter_overrides({{"enable_lifecycle_services", false}});
```

Fixes #5305

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: orebai <[email protected]>

* fix: Rename PushRosNamespace to PushROSNamespace for consistency across launch files

Signed-off-by: orebai <[email protected]>

---------

Signed-off-by: orebai <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: nishalangovender <[email protected]>
Signed-off-by: Nishalan Govender <[email protected]>
Co-authored-by: orebai <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
Co-authored-by: Nishalan Govender <[email protected]>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Sushant-Chavan added a commit to Sushant-Chavan/navigation2 that referenced this pull request Aug 5, 2025
* Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237)

* Revert "Fix Ci from key signing (ros-navigation#5220)"

This reverts the changes to the Dockerfile done in 1345c22.

Signed-off-by: Nils-Christian Iseke <[email protected]>

* Update Cache Version

Signed-off-by: Nils-Christian Iseke <[email protected]>

---------

Signed-off-by: Nils-Christian Iseke <[email protected]>

* enable_groot_monitoring_ false (ros-navigation#5246)

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>

* Updating readme table for kilted release (ros-navigation#5249)

* updating readme table for kilted release

Signed-off-by: Steve Macenski <[email protected]>

* Updating table lint

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>

* Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543)

* min_distance_to_obstacle

Signed-off-by: Guillaume Doisy <[email protected]>

* suggestion to time base and combine

Signed-off-by: Guillaume Doisy <[email protected]>

* typo

Signed-off-by: Guillaume Doisy <[email protected]>

* use min_approach_linear_velocity

Signed-off-by: Guillaume Doisy <[email protected]>

---------

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>

* Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251)

* Update amcl_node.hpp

Signed-off-by: Steve Macenski <[email protected]>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Working for Kilted, Jazzy

Signed-off-by: Steve Macenski <[email protected]>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>

* Change max_cost default to 254 (ros-navigation#5256)

Signed-off-by: Tony Najjar <[email protected]>

* Route server corner smoothing (ros-navigation#5226)

* added edge length method

Signed-off-by: Alexander Yuen <[email protected]>

* Added corner arc class

Signed-off-by: Alexander Yuen <[email protected]>

* replaced double vectors with Coordinates, added methods to return start and end coordinates

Signed-off-by: Alexander Yuen <[email protected]>

* using Coordinates, fixed direction of tangents

Signed-off-by: Alexander Yuen <[email protected]>

* added corner arc in header, added logger in protected variable

Signed-off-by: Alexander Yuen <[email protected]>

* first pass of corner smoothing algorithm

Signed-off-by: Alexander Yuen <[email protected]>

* reassigning next edge to have a different start, if a corner occurs before it

Signed-off-by: Alexander Yuen <[email protected]>

* using unique pointer instead of raw pointers for new edges and nodes

Signed-off-by: Alexander Yuen <[email protected]>

* added smoothing parameter

Signed-off-by: Alexander Yuen <[email protected]>

* made angle of interpolation a parameter

Signed-off-by: Alexander Yuen <[email protected]>

* const for return methods, added flag for smoothing corners

Signed-off-by: Alexander Yuen <[email protected]>

* moved getEdgeLength() into the Directional Edge struct

Signed-off-by: Alexander Yuen <[email protected]>

* using float instead of double

Signed-off-by: Alexander Yuen <[email protected]>

* smoothing radius is float, couple methods moved to protected

Signed-off-by: Alexander Yuen <[email protected]>

* removed signed_angle_ as a member variable

Signed-off-by: Alexander Yuen <[email protected]>

* removed unnecessary member variables

Signed-off-by: Alexander Yuen <[email protected]>

* removed angle of interpolation and inferring it from path density and radius instead

Signed-off-by: Alexander Yuen <[email protected]>

* consolidated corner arc into one header function

Signed-off-by: Alexander Yuen <[email protected]>

* readded newline

Signed-off-by: Alexander Yuen <[email protected]>

* changed corner arc to corner smoothing

Signed-off-by: Alexander Yuen <[email protected]>

* replaced the use of edges with coordinates to generate smoothing arc, removed storage of nodes and edges

Signed-off-by: Alexander Yuen <[email protected]>

* linting

Signed-off-by: Alexander Yuen <[email protected]>

* fixing cpplint

Signed-off-by: Alexander Yuen <[email protected]>

* linting for headers

Signed-off-by: Alexander Yuen <[email protected]>

* cpplinting

Signed-off-by: Alexander Yuen <[email protected]>

* Update nav2_route/src/path_converter.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_route/src/path_converter.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_route/src/path_converter.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_route/src/path_converter.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_route/include/nav2_route/corner_smoothing.hpp

Signed-off-by: Steve Macenski <[email protected]>

* fixed divide by zeros and accessing empty route.edges

Signed-off-by: Alexander Yuen <[email protected]>

* uncrustify linting

Signed-off-by: Alexander Yuen <[email protected]>

* cpp linting

Signed-off-by: Alexander Yuen <[email protected]>

* path converter linting

Signed-off-by: Alexander Yuen <[email protected]>

* changed all doubles to floats

Signed-off-by: Alexander Yuen <[email protected]>

* added check for edges that are colinear to avoid divide by 0, fixed final edge interpolation

Signed-off-by: Alexander Yuen <[email protected]>

* linting

Signed-off-by: Alexander Yuen <[email protected]>

* Update nav2_route/include/nav2_route/corner_smoothing.hpp

Signed-off-by: Steve Macenski <[email protected]>

* added doxygen for corner arc class

Signed-off-by: Alexander Yuen <[email protected]>

* added warning message if corner can't be smoothed

Signed-off-by: Alexander Yuen <[email protected]>

* added smooth_corners to the nav2 params file

Signed-off-by: Alexander Yuen <[email protected]>

* added smoothing flag and radius parameter to README.md'

Signed-off-by: Alexander Yuen <[email protected]>

* typo in README

Signed-off-by: Alexander Yuen <[email protected]>

* added testing for corner smoothing

Signed-off-by: Alexander Yuen <[email protected]>

* Update nav2_route/include/nav2_route/corner_smoothing.hpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Alexander Yuen <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* Conserve curvature with LIMIT action (ros-navigation#5255)

* Conserve curvature with LIMIT action

Signed-off-by: Tony Najjar <[email protected]>

* fix format

Signed-off-by: Tony Najjar <[email protected]>

* fix test

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>

* Parametrizing obstacle layer tf filter tolerance (ros-navigation#5261)

Signed-off-by: Marco Bassa <[email protected]>

* Add namespace support for rviz costmap cost tool (ros-navigation#5268)

Signed-off-by: Maurice-1235 <[email protected]>

* Fix/smac planner orientation goals (ros-navigation#5235)

* cherry pick

Signed-off-by: Stevedan Omodolor <[email protected]>

* cherry pick 6a74ba6

Signed-off-by: Stevedan Omodolor <[email protected]>

* cherrpy pick

Signed-off-by: Stevedan Omodolor <[email protected]>

* include x11 forwarding

Signed-off-by: Stevedan Omodolor <[email protected]>

* kind of working version

Signed-off-by: Stevedan Omodolor <[email protected]>

* cleanup

Signed-off-by: Stevedan Omodolor <[email protected]>

* formatting

Signed-off-by: Stevedan Omodolor <[email protected]>

* minor format change

Signed-off-by: Stevedan Omodolor <[email protected]>

* change naming

Signed-off-by: Stevedan Omodolor <[email protected]>

* minor changes

Signed-off-by: Stevedan Omodolor <[email protected]>

* working with new changes

Signed-off-by: Stevedan Omodolor <[email protected]>

* Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237)

* Revert "Fix Ci from key signing (ros-navigation#5220)"

This reverts the changes to the Dockerfile done in 1345c22.

Signed-off-by: Nils-Christian Iseke <[email protected]>

* Update Cache Version

Signed-off-by: Nils-Christian Iseke <[email protected]>

---------

Signed-off-by: Nils-Christian Iseke <[email protected]>
Signed-off-by: Stevedan Omodolor <[email protected]>

* Revert back

Signed-off-by: Stevedan Omodolor <[email protected]>

* enable_groot_monitoring_ false (ros-navigation#5246)

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Signed-off-by: Stevedan Omodolor <[email protected]>

* Updating readme table for kilted release (ros-navigation#5249)

* updating readme table for kilted release

Signed-off-by: Steve Macenski <[email protected]>

* Updating table lint

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Stevedan Omodolor <[email protected]>

* Add min_distance_to_obstacle parameter to RPP (ros-navigation#4543)

* min_distance_to_obstacle

Signed-off-by: Guillaume Doisy <[email protected]>

* suggestion to time base and combine

Signed-off-by: Guillaume Doisy <[email protected]>

* typo

Signed-off-by: Guillaume Doisy <[email protected]>

* use min_approach_linear_velocity

Signed-off-by: Guillaume Doisy <[email protected]>

---------

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Signed-off-by: Stevedan Omodolor <[email protected]>

* Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support (ros-navigation#5251)

* Update amcl_node.hpp

Signed-off-by: Steve Macenski <[email protected]>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Working for Kilted, Jazzy

Signed-off-by: Steve Macenski <[email protected]>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update amcl_node.cpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Stevedan Omodolor <[email protected]>

* Change max_cost default to 254 (ros-navigation#5256)

Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Stevedan Omodolor <[email protected]>

* linter

Signed-off-by: Stevedan Omodolor <[email protected]>

* remove const

Signed-off-by: Stevedan Omodolor <[email protected]>

* pass const pointer by value

Signed-off-by: Stevedan Omodolor <[email protected]>

* pass const pointer by value

Signed-off-by: Stevedan Omodolor <[email protected]>

* remove unused param

Signed-off-by: Stevedan Omodolor <[email protected]>

---------

Signed-off-by: Stevedan Omodolor <[email protected]>
Signed-off-by: Nils-Christian Iseke <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
Co-authored-by: Nils-Christian Iseke <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Tony Najjar <[email protected]>

* Fix backport compiler warning (ros-navigation#5277)

Signed-off-by: Steve Macenski <[email protected]>

* Fix ament mypy (ros-navigation#5280)

* Configured nav2_loopback_sim to be compliant with mypy.

Signed-off-by: Leander Stephen D'Souza <[email protected]>

* Configured nav2_simple_commander to be compliant with mypy.

Signed-off-by: Leander Stephen D'Souza <[email protected]>

* Configured nav2_system_tests to be compliant with mypy.

Signed-off-by: Leander Stephen D'Souza <[email protected]>

---------

Signed-off-by: Leander Stephen D'Souza <[email protected]>

* Publish zero velocitiy in case of goal failure (ros-navigation#5279)

Signed-off-by: haider8645 <[email protected]>

* Update PULL_REQUEST_TEMPLATE.md

Signed-off-by: Steve Macenski <[email protected]>

* Use fixed thresholds for Trinary yaml (ros-navigation#5278)

Signed-off-by: Adi Vardi <[email protected]>

* Add missing include of algorithm in differential_motion_model.cpp (ros-navigation#5293)

Signed-off-by: Silvio Traversaro <[email protected]>

* Remove unused unistd.h header from route_tool.cpp (ros-navigation#5292)

Signed-off-by: Silvio Traversaro <[email protected]>

* Fix compilation of nav2_smac_planner on Windows (ros-navigation#5291)

Signed-off-by: Silvio <[email protected]>

* Large Nav2 Node, Utils, and Interface Refactor (ros-navigation#5288)

* initial unorganized prototype

Signed-off-by: Steve Macenski <[email protected]>

* break out files and add doxygen

Signed-off-by: Steve Macenski <[email protected]>

* Adding refactor for nav2_ros_common and new ROS interface factories

Signed-off-by: Steve Macenski <[email protected]>

* fixing CI - not sure how that got through merge conflicts

Signed-off-by: Steve Macenski <[email protected]>

* Lifecycle publisher a missing test

Signed-off-by: Steve Macenski <[email protected]>

* system tests

Signed-off-by: Steve Macenski <[email protected]>

* default

Signed-off-by: Steve Macenski <[email protected]>

* activating publishers

Signed-off-by: Steve Macenski <[email protected]>

* temp disable allow param qos overrides

Signed-off-by: Steve Macenski <[email protected]>

* API update for new constructor option

Signed-off-by: Steve Macenski <[email protected]>

* Supporting Jazzy and abstracting util

Signed-off-by: Steve Macenski <[email protected]>

* Review round 1

Signed-off-by: Steve Macenski <[email protected]>

* Adding Nav2 Publisher and Subscriber objects to later build upon

Signed-off-by: Steve Macenski <[email protected]>

* Adding additional ::SharedPtr for readability

Signed-off-by: Steve Macenski <[email protected]>

* fix bug

Signed-off-by: Steve Macenski <[email protected]>

* fixing Jazzy support

Signed-off-by: Steve Macenski <[email protected]>

* missed one last spot

Signed-off-by: Steve Macenski <[email protected]>

* Adding migration instructions

Signed-off-by: Steve Macenski <[email protected]>

* more context

Signed-off-by: Steve Macenski <[email protected]>

* Adding migration context

Signed-off-by: Steve Macenski <[email protected]>

* precommit

Signed-off-by: Steve Macenski <[email protected]>

* adding missing dep

Signed-off-by: Steve Macenski <[email protected]>

* Updating system tess

Signed-off-by: Steve Macenski <[email protected]>

* more

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>

* Adding logging for matched events and dropped messages into pub/sub of new nav2_ros_common package. Also adding QoS overrides default ON (ros-navigation#5302)

* Adding logging for matched events and dropped messages

Signed-off-by: Steve Macenski <[email protected]>

* toggle on

Signed-off-by: Steve Macenski <[email protected]>

* apply for smac 2D

Signed-off-by: Steve Macenski <[email protected]>

* Update interface_factories.hpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>

* Add LaunchConfigAsBool (Fixes ros-navigation#5233) (ros-navigation#5301)

* Add LaunchConfigAsBool (Fixes ros-navigation#5233)

Signed-off-by: nishalangovender <[email protected]>

* Fix Linting

Signed-off-by: nishalangovender <[email protected]>

* Fix ament_mypy and pre-commit

Signed-off-by: nishalangovender <[email protected]>

* Added Type Annotations

Signed-off-by: Nishalan Govender <[email protected]>

* mypy ignore

Signed-off-by: Nishalan Govender <[email protected]>

* launch.Substitution

Signed-off-by: Nishalan Govender <[email protected]>

* Update All Bools in nav2_bringup

Signed-off-by: Nishalan Govender <[email protected]>

---------

Signed-off-by: nishalangovender <[email protected]>
Signed-off-by: Nishalan Govender <[email protected]>

* Create claude.yml

Signed-off-by: Steve Macenski <[email protected]>

* Update claude.yml

Signed-off-by: Steve Macenski <[email protected]>

* Update claude.yml

Signed-off-by: Steve Macenski <[email protected]>

* Update claude.yml for authorized users

Signed-off-by: Steve Macenski <[email protected]>

* Update claude.yml

Signed-off-by: Steve Macenski <[email protected]>

* Update claude.yml

Signed-off-by: Steve Macenski <[email protected]>

* Adding clear costmap around pose service option (ros-navigation#5309)

* Adding clear costmap around pose impl

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_msgs/srv/ClearCostmapAroundPose.srv

Signed-off-by: Steve Macenski <[email protected]>

* Adding APIs for simple commander

Signed-off-by: Steve Macenski <[email protected]>

* linting

Signed-off-by: Steve Macenski <[email protected]>

* adding import

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>

* Fix compiler errors in nav2_map_server

* Fix compiler errors in nav2_costmap_2d

* Add support for enable_lifecycle_services parameter in LifecycleNode (ros-navigation#5307)

Expose the enable_communication_interface parameter from rclcpp_lifecycle::LifecycleNode
through nav2's LifecycleNode wrapper. This allows users to disable lifecycle communication
interfaces when manually managing node lifecycle transitions.

The parameter can be set via NodeOptions parameter overrides:
```cpp
rclcpp::NodeOptions options;
options.parameter_overrides({{"enable_lifecycle_services", false}});
```

Fixes ros-navigation#5305

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

---------

Signed-off-by: Nils-Christian Iseke <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Alexander Yuen <[email protected]>
Signed-off-by: Marco Bassa <[email protected]>
Signed-off-by: Maurice-1235 <[email protected]>
Signed-off-by: Stevedan Omodolor <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: haider8645 <[email protected]>
Signed-off-by: Adi Vardi <[email protected]>
Signed-off-by: Silvio Traversaro <[email protected]>
Signed-off-by: Silvio <[email protected]>
Signed-off-by: nishalangovender <[email protected]>
Signed-off-by: Nishalan Govender <[email protected]>
Co-authored-by: Nils-Christian Iseke <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
Co-authored-by: Tony Najjar <[email protected]>
Co-authored-by: alexanderjyuen <[email protected]>
Co-authored-by: Marco Bassa <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
Co-authored-by: Stevedan Ogochukwu Omodolor <[email protected]>
Co-authored-by: Leander Stephen D'Souza <[email protected]>
Co-authored-by: Haider <[email protected]>
Co-authored-by: Adi Vardi <[email protected]>
Co-authored-by: Silvio Traversaro <[email protected]>
Co-authored-by: Nishalan Govender <[email protected]>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Sep 11, 2025
…avigation#5318)

* Adding clear costmap around pose service option (ros-navigation#5309)

(cherry picked from commit c0bf67e
Signed-off-by: dw25628 <[email protected]>

* Linting

Signed-off-by: dw25628 <[email protected]>

* Removed __init__.py that came in with cherry pick

Signed-off-by: dw25628 <[email protected]>

---------

Signed-off-by: dw25628 <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Dec 1, 2025
…avigation#5318)

* Adding clear costmap around pose service option (ros-navigation#5309)

(cherry picked from commit c0bf67e
Signed-off-by: dw25628 <[email protected]>

* Linting

Signed-off-by: dw25628 <[email protected]>

* Removed __init__.py that came in with cherry pick

Signed-off-by: dw25628 <[email protected]>

---------

Signed-off-by: dw25628 <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Dec 3, 2025
* Jazzy Sync 7: May 29 2025 (ros-navigation#5211)

* Dynamic param patterns (ros-navigation#4971)

* redesign dynamic param patterns

Signed-off-by: Nils-ChristianIseke <[email protected]>

* change cache version

Signed-off-by: Nils-ChristianIseke <[email protected]>

* check that parameter of type double are  >=0.0

Signed-off-by: Nils-ChristianIseke <[email protected]>

---------

Signed-off-by: Nils-ChristianIseke <[email protected]>

* [nav2_behavior_tree] Add force_use_current_pose to ComputePathToPoseAction (ros-navigation#4925)

* Add force_use_current_pose

Signed-off-by: Guillaume Doisy <[email protected]>

* xml update

Signed-off-by: Guillaume Doisy <[email protected]>

* rename to use_start

Signed-off-by: Guillaume Doisy <[email protected]>

* lint

Signed-off-by: Guillaume Doisy <[email protected]>

* descriptions

Signed-off-by: Guillaume Doisy <[email protected]>

* simplify logic

Signed-off-by: Guillaume Doisy <[email protected]>

---------

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>

* [CostmapTopicCollisionChecker] Alternative constructor with footprint string (ros-navigation#4926)

* [CostmapTopicCollisionChecker] Alternative constructor with footprint

Signed-off-by: Guillaume Doisy <[email protected]>

* raw pointer

Signed-off-by: Guillaume Doisy <[email protected]>

* suggestions from review

Signed-off-by: Guillaume Doisy <[email protected]>

---------

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>

* Merged Fix navfn_planner from humble PR ros-navigation#5087 (ros-navigation#5092)

* merged changes from humble for goal.header fix

* reverted back, error in merge

* ported goal.header fix in navfn_planner.cpp from humble

* reverted to navfn_planner.cpp to origin/main

* merged navfn_planner.cpp from humble

* fixed the merge

* Update map_io library to use Eigen method for faster map loading (ros-navigation#5071)

* Update map_io library to use opencv method for faster map loading

Signed-off-by: Vignesh T <[email protected]>

* Update pre-commit config changes

Signed-off-by: Vignesh T <[email protected]>

* Use Eigen approach instead of OpenCV

Signed-off-by: Vignesh T <[email protected]>

* Update pre-commit changes

Signed-off-by: Vignesh T <[email protected]>

* Update include header include order

Signed-off-by: Vignesh T <[email protected]>

* Remove intermediary alpha matrix

Signed-off-by: Vignesh T <[email protected]>

* Add comments for the code understanding

Signed-off-by: Vignesh T <[email protected]>

* Fix else braces rule issue

Signed-off-by: Vignesh T <[email protected]>

* Create and use alpha_matrix when applying mask

Signed-off-by: Vignesh T <[email protected]>

* Update pre-commit changes

Signed-off-by: Vignesh T <[email protected]>

* Take flip part out of if-else

Signed-off-by: Vignesh T <[email protected]>

* Update pre-commit changes

Signed-off-by: Vignesh T <[email protected]>

---------

Signed-off-by: Vignesh T <[email protected]>

* Precompute yaw trigonometric values in smac planner (ros-navigation#5109)

Signed-off-by: mini-1235 <[email protected]>

* removing the start navigation message in the paused state from rviz buttons (ros-navigation#5137)

Signed-off-by: Pradheep <[email protected]>

* Show error if inflation radius is smaller than circumscribed radius (ros-navigation#5148)

* Warn if inflation radius is smaller than circumscribed radius

Signed-off-by: Tony Najjar <[email protected]>

* Update nav2_mppi_controller/src/critics/cost_critic.cpp

Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>

* Update nav2_smac_planner/include/nav2_smac_planner/utils.hpp

Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* Prevent MPPI controller from resetting speed limits upon goal execution. (ros-navigation#5165)

Signed-off-by: Leander Stephen D'Souza <[email protected]>

* Fixing docking server when already docked at the requeste ddock (ros-navigation#5171)

Signed-off-by: Steve Macenski <[email protected]>

* Adding parameter util to node utils (ros-navigation#5154)

* Adding declare_or_get_param util to node utils

Signed-off-by: Marco Bassa <[email protected]>

* Adding test for declare_or_get_param util

Signed-off-by: Marco Bassa <[email protected]>

* Adding declare_or_get_parameter function by type, using explicit variable names, disabling param warnings by default

Signed-off-by: Marco Bassa <[email protected]>

* Update nav2_util/test/test_node_utils.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Fixing codecove test

Signed-off-by: Marco Bassa <[email protected]>

* Catching possible exception in declare_or_get_by_type

Signed-off-by: Marco Bassa <[email protected]>

* Templating return type of declare parameter by value

Signed-off-by: Marco Bassa <[email protected]>

---------

Signed-off-by: Marco Bassa <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* added config for laserscan in lb-sim (ros-navigation#5174)

* added config for laserscan in lb-sim

Signed-off-by: RamanaBotta <[email protected]>

* fixing ament_flake8 errors

Signed-off-by: RamanaBotta <[email protected]>

* review: use_inf is default:true and added parameters on readme ros-navigation#4992

Signed-off-by: RamanaBotta <[email protected]>

* refactor: meaningfull value for scan_angle_increment

Signed-off-by: RamanaBotta <[email protected]>

---------

Signed-off-by: RamanaBotta <[email protected]>
Co-authored-by: RamanaBotta <[email protected]>

* Publish planned footprints after smoothing (ros-navigation#5155)

* Publish planned footprints after smoothing

Signed-off-by: Tony Najjar <[email protected]>

* Revert "Publish planned footprints after smoothing"

This reverts commit c9b349a.

* Add smoothed footprints publishing

Signed-off-by: Tony Najjar <[email protected]>

* fix formatting

Signed-off-by: Tony Najjar <[email protected]>

* Fix indentation for publisher creation in SmacPlannerHybrid and SmacPlannerLattice

Signed-off-by: Tony Najjar <[email protected]>

* address PR comments

Signed-off-by: Tony Najjar <[email protected]>

* fixes

Signed-off-by: Tony Najjar <[email protected]>

* fix build error

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>

* fixing deprecation warning (ros-navigation#5182)

Signed-off-by: Steve Macenski <[email protected]>

* Adding missing dep to loopback sim (ros-navigation#5204)

* Adding missing dep

Signed-off-by: Steve Macenski <[email protected]>

* typo

Signed-off-by: Steve Macenski <[email protected]>

* updating fix

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>

* Adding parameter warn_when_defaulting_parameters to control default parameter warnings (ros-navigation#5189)

* Adding a parameter warn_when_defaulting_parameters to control default parameter warnings instead of using a flag

Signed-off-by: Marco Bassa <[email protected]>

* Adding parameter strict_param_loading for optionally throwing an exception if parameter overrides are missing

Signed-off-by: Marco Bassa <[email protected]>

* Using default false declaration instead of declare_or_get in param util

Signed-off-by: Marco Bassa <[email protected]>

---------

Signed-off-by: Marco Bassa <[email protected]>

* bumping to 1.3.7 for release

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Nils-ChristianIseke <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Vignesh T <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: Pradheep <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Marco Bassa <[email protected]>
Signed-off-by: RamanaBotta <[email protected]>
Co-authored-by: Nils-Christian Iseke <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Sandeep Dutta <[email protected]>
Co-authored-by: Vignesh T <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
Co-authored-by: Pradheep Krishna <[email protected]>
Co-authored-by: Tony Najjar <[email protected]>
Co-authored-by: Leander Stephen D'Souza <[email protected]>
Co-authored-by: Marco Bassa <[email protected]>
Co-authored-by: Raman <[email protected]>
Co-authored-by: RamanaBotta <[email protected]>

* Fixing Jazzy CI via new ROS 2 keys

Signed-off-by: Steve Macenski <[email protected]>

* Revert "Fix Ci from key signing (ros-navigation#5220)" (backport ros-navigation#5237) (ros-navigation#5239)

* Revert "Fix Ci from key signing (ros-navigation#5220)" (ros-navigation#5237)

* Revert "Fix Ci from key signing (ros-navigation#5220)"

This reverts the changes to the Dockerfile done in 1345c22.

Signed-off-by: Nils-Christian Iseke <[email protected]>

* Update Cache Version

Signed-off-by: Nils-Christian Iseke <[email protected]>

---------

Signed-off-by: Nils-Christian Iseke <[email protected]>
(cherry picked from commit 7f561b0)

# Conflicts:
#	.circleci/config.yml

* Update config.yml

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Nils-Christian Iseke <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* Backport bidirectional settings ros-navigation#4954 (ros-navigation#5260)

Signed-off-by: Tatsuro Sakaguchi <[email protected]>

* Add namespace support for rviz costmap cost tool (ros-navigation#5271)

Signed-off-by: Maurice-1235 <[email protected]>

* Use fixed thresholds for Trinary yaml (ros-navigation#5278) (ros-navigation#5286)

(cherry picked from commit 829e683)

Signed-off-by: Adi Vardi <[email protected]>
Co-authored-by: Adi Vardi <[email protected]>

* Clear costmap around pose jazzy (backport ros-navigation#5309) (ros-navigation#5318)

* Adding clear costmap around pose service option (ros-navigation#5309)

(cherry picked from commit c0bf67e
Signed-off-by: dw25628 <[email protected]>

* Linting

Signed-off-by: dw25628 <[email protected]>

* Removed __init__.py that came in with cherry pick

Signed-off-by: dw25628 <[email protected]>

---------

Signed-off-by: dw25628 <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* Backport "Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In" (ros-navigation#5378)

* Option to Reduce Lethal to High-Cost Navigable To Get Out of Keepout Zones if Wandered In (ros-navigation#5187)

* Adding toggle option of keepout zone

Signed-off-by: Steve Macenski <[email protected]>

* Default off

Signed-off-by: Steve Macenski <[email protected]>

* Join conditions

Signed-off-by: Steve Macenski <[email protected]>

* spell check

Signed-off-by: Steve Macenski <[email protected]>

* copilot suggestions

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp

Co-authored-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_costmap_2d/plugins/costmap_filters/keepout_filter.cpp

Co-authored-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>

* Update keepout_filter.cpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Leander Stephen D'Souza <[email protected]>

* Revert bringup params changes

Signed-off-by: Maurice <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Maurice <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
Co-authored-by: Leander Stephen D'Souza <[email protected]>

* Adding minimum range to PC2 in collision monitor (backport ros-navigation#5392) (ros-navigation#5393)

* Adding minimum range to PC2 in collision monitor (ros-navigation#5392)

Signed-off-by: SteveMacenski <[email protected]>
(cherry picked from commit 40a0451)

# Conflicts:
#	nav2_collision_monitor/src/pointcloud.cpp

* Update pointcloud.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update pointcloud.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update sources_test.cpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* Construct TF listeners passing nodes, spinning on separate thread (backport ros-navigation#5406) (ros-navigation#5431)

* Construct TF listeners passing nodes, spinning on separate thread (ros-navigation#5406)

* Construct TF listeners passing nodes, spinning on separate thread

Signed-off-by: Patrick Roncagliolo <[email protected]>

* (tentative) pin down of the impacting change

Signed-off-by: Patrick Roncagliolo <[email protected]>

---------

Signed-off-by: Patrick Roncagliolo <[email protected]>
(cherry picked from commit 1468484)

# Conflicts:
#	nav2_route/src/route_server.cpp

* Delete nav2_route/src/route_server.cpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Patrick Roncagliolo <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* Fix lifecycle manager deadlock during shutdown (ros-navigation#5448)

Signed-off-by: Jacob Visser <[email protected]>

* fix 5456 (ros-navigation#5458)

Signed-off-by: David G <[email protected]>

* backport the fix for setting binary_state as the default (ros-navigation#5459)

Signed-off-by: olaghattas <[email protected]>

* Sync Jazzy Aug 19, 2025 1.4.1 (ros-navigation#5469)

* Conserve curvature with LIMIT action (ros-navigation#5255)

* Conserve curvature with LIMIT action

Signed-off-by: Tony Najjar <[email protected]>

* fix format

Signed-off-by: Tony Najjar <[email protected]>

* fix test

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>

* Adding epsilon for voxel_layer precision loss (ros-navigation#5314)

* Adding epsilon for voxel_layer precision loss

Signed-off-by: bhx <[email protected]>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <[email protected]>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: bhx <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* fix: correct ThroughActionResult type alias in would_a_planner_recovery_help_condition (ros-navigation#5326)

The ThroughActionResult type alias was incorrectly referencing Action::Result 
instead of ThroughAction::Result, causing the condition to not work properly 
for ComputePathThroughPoses actions.

Fixes ros-navigation#5324

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Adding slow down at target heading to RPP Controller (ros-navigation#5361)

* Adding slow down at target heading to RPP

Signed-off-by: SteveMacenski <[email protected]>

* Update test_regulated_pp.cpp

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: SteveMacenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>

* Eexception rethrow in dockRobot method (ros-navigation#5364)

Signed-off-by: Alberto Tudela <[email protected]>

* Add global min obstacle height in voxel layer (ros-navigation#5389)

* Add min obstacle height in voxel layer

Signed-off-by: mini-1235 <[email protected]>

* Fix linting

Signed-off-by: Maurice <[email protected]>

---------

Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: Maurice <[email protected]>

* [DEX] Enforce 3 digits precision (ros-navigation#5398)

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>

* [static_layer] limit comparison precision (ros-navigation#5405)

* [DEX] limit comparison precision

Signed-off-by: Guillaume Doisy <[email protected]>

* EPSILON 1e-5

Signed-off-by: Guillaume Doisy <[email protected]>

---------

Signed-off-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>

* Smooth path even if goal pose is so much near to the robot (ros-navigation#5423)

* Smooth path even if goal pose is so much near to the robot

Signed-off-by: CihatAltiparmak <[email protected]>

* Apply suggestions

Signed-off-by: CihatAltiparmak <[email protected]>

* Remove unnecessary diff

Signed-off-by: CihatAltiparmak <[email protected]>

---------

Signed-off-by: CihatAltiparmak <[email protected]>

* Fix KeepoutFilter on the ARM architecture (ros-navigation#5436)

Signed-off-by: Sushant Chavan <[email protected]>

* Fix missing dependency (ros-navigation#5460)

* bump to 1.3.8 for Jazzy release Aug 19, 2025

Signed-off-by: SteveMacenski <[email protected]>

* load balance CI

Signed-off-by: SteveMacenski <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: bhx <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: SteveMacenski <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: Maurice <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: CihatAltiparmak <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
Co-authored-by: Tony Najjar <[email protected]>
Co-authored-by: hutao <[email protected]>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Alberto Tudela <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Cihat Kurtuluş Altıparmak <[email protected]>
Co-authored-by: Sushant Chavan <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>

* fix: Move SmootherParams declaration outside smooth_path conditional (ros-navigation#5473) (ros-navigation#5474)

Fixes crash when dynamically changing smooth_path parameter from false to true.
The issue occurred because SmootherParams were only declared when smooth_path
was initially true, causing ParameterModifiedInCallbackException when trying
to declare parameters within the dynamic parameter callback.

Now SmootherParams are always declared, making them available for dynamic
reconfiguration regardless of the initial smooth_path value.

Fixes ros-navigation#5472


(cherry picked from commit 69a60df)

Co-authored-by: Steve Macenski <[email protected]>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

* Replace last pose if only orientation differs in Navfn (ros-navigation#5490) (ros-navigation#5492)

(cherry picked from commit ff80727)

Signed-off-by: mini-1235 <[email protected]>
Co-authored-by: mini-1235 <[email protected]>

* Manual Backport Route Server to Jazzy (ros-navigation#5517)

* Manual backport of Route Server to Jazzy

Signed-off-by: Steve Macenski <[email protected]>

* linting

Signed-off-by: Steve Macenski <[email protected]>

* Fix backport error

Signed-off-by: Steve Macenski <[email protected]>

* lint

Signed-off-by: Steve Macenski <[email protected]>

* Adding in Nav2 BT + Launch

Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Steve Macenski <[email protected]>

* Jazzy Sync Sept 19, 2025 1.3.9 (ros-navigation#5540)

* Fix dynamic param SmacPlannerLattice  (ros-navigation#5478)

* Fix SmacPlannerLattice dynamic parameter early exit

Signed-off-by: Tony Najjar <[email protected]>

* remove comment

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>

* Fix duplicate poses with computePlanThroughPoses (ros-navigation#5488)

* fix-duplicate-poses

Signed-off-by: Tony Najjar <[email protected]>

* Update nav2_planner/src/planner_server.cpp

Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* Fix seg fault (ros-navigation#5501)

* Fix segmentation fault

Signed-off-by: Tony Najjar <[email protected]>

* fix linting

Signed-off-by: Tony Najjar <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>

* Add a service for enabling/disabling the collision monitor (ros-navigation#5493)

* Added std_srvs package to dependencies

Signed-off-by: Abhishekh Reddy <[email protected]>

* Declared service and callback for enabling/disabling collision monitor

Signed-off-by: Abhishekh Reddy <[email protected]>

* Declared a variable to store collision monitor enable/disable state

Signed-off-by: Abhishekh Reddy <[email protected]>

* Added initialization for collision monitor enable/disable service

Signed-off-by: Abhishekh Reddy <[email protected]>

* Implemented service callback for collision monitor enable/disable service

Signed-off-by: Abhishekh Reddy <[email protected]>

* Removed std_srvs package dependency

Signed-off-by: Abhishekh Reddy <[email protected]>

* Added Toggle interface

Signed-off-by: Abhishekh Reddy <[email protected]>

* Replaced Trigger interface with the new Toggle interface

Signed-off-by: Abhishekh Reddy <[email protected]>

* Added default initialization for enabled flag

Signed-off-by: Abhishekh Reddy <[email protected]>

* Fixed toggle service name

Signed-off-by: Abhishekh Reddy <[email protected]>

* Updated toggle logic for collision monitor

Signed-off-by: Abhishekh Reddy <[email protected]>

* Added a new line at the end of file

Signed-off-by: Abhishekh Reddy <[email protected]>

* Update nav2_collision_monitor/src/collision_monitor_node.cpp

Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Abhishekh Reddy <[email protected]>

* Update nav2_collision_monitor/src/collision_monitor_node.cpp

Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Abhishekh Reddy <[email protected]>

* Added enabled check for logging

Signed-off-by: Abhishekh Reddy <[email protected]>

* Added a unit test for toggle service

Signed-off-by: Abhishekh Reddy <[email protected]>

* Made the getter const and added a comment

Signed-off-by: Abhishekh Reddy <[email protected]>

* Replaced rclcpp::spin_some

Signed-off-by: Abhishekh Reddy <[email protected]>

---------

Signed-off-by: Abhishekh Reddy <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>

* bump Jazzy to 1.3.9 for release

Signed-off-by: SteveMacenski <[email protected]>

* Change service type for collision monitor

Signed-off-by: Steve Macenski <[email protected]>

* Fix backport error

Signed-off-by: SteveMacenski <[email protected]>

* update

Signed-off-by: SteveMacenski <[email protected]>

---------

Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Abhishekh Reddy <[email protected]>
Signed-off-by: SteveMacenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Tony Najjar <[email protected]>
Co-authored-by: Abhishekh Reddy <[email protected]>

* Update package version from 1.1.0 to 1.3.9

Signed-off-by: Steve Macenski <[email protected]>

* Add support for dynamically changing keepout zone (ros-navigation#5429) (ros-navigation#5542)

* Add support for dynamically changing keepout zone



* Linting



* Revert binary and speed changes



---------


(cherry picked from commit e690ef0)

Signed-off-by: mini-1235 <[email protected]>
Co-authored-by: mini-1235 <[email protected]>

* Fix bad_weak_ptr in createBond() by using shared_ptr (backport ros-navigation#5341) (ros-navigation#5563)

Signed-off-by: ymd-stella <[email protected]>

* Fixed crash due to incorrect string construction (ros-navigation#5606) (ros-navigation#5613)

(cherry picked from commit 48e7e06)

Signed-off-by: Jay Herpin <[email protected]>
Co-authored-by: Jay Herpin <[email protected]>

* Add dependency on nav2_route in package.xml (ros-navigation#5639)

Signed-off-by: Steve Macenski <[email protected]>

* Revert ros-navigation#4971 in Jazzy (ros-navigation#5640)

* Revert ros-navigation#4971 in Jazzy

Signed-off-by: mini-1235 <[email protected]>

* Add

Signed-off-by: mini-1235 <[email protected]>

---------

Signed-off-by: mini-1235 <[email protected]>

* Bumping to 1.3.10 for urgent jazzy regression fixes (ros-navigation#5650)

Signed-off-by: SteveMacenski <[email protected]>

* Backporting custom height point field into Jazzy. (ros-navigation#5646)

* Summary commit of all changes for adding custom pointcloud field height. (ros-navigation#5586)

Doing this to clear out unsigned commits from history.

Signed-off-by: Greg Anderson <[email protected]>

* Corrected parameter declaration methods that aren't part of Jazzy.
Fixed parameter typo from some manual merging in pointcloud.cpp

Signed-off-by: Greg Anderson <[email protected]>

---------

Signed-off-by: Greg Anderson <[email protected]>

---------

Signed-off-by: Nils-ChristianIseke <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Signed-off-by: Vignesh T <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: Pradheep <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Tony Najjar <[email protected]>
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Marco Bassa <[email protected]>
Signed-off-by: RamanaBotta <[email protected]>
Signed-off-by: Tatsuro Sakaguchi <[email protected]>
Signed-off-by: Maurice-1235 <[email protected]>
Signed-off-by: Adi Vardi <[email protected]>
Signed-off-by: dw25628 <[email protected]>
Signed-off-by: Maurice <[email protected]>
Signed-off-by: Jacob Visser <[email protected]>
Signed-off-by: David G <[email protected]>
Signed-off-by: olaghattas <[email protected]>
Signed-off-by: bhx <[email protected]>
Signed-off-by: SteveMacenski <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: CihatAltiparmak <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
Signed-off-by: Abhishekh Reddy <[email protected]>
Signed-off-by: ymd-stella <[email protected]>
Signed-off-by: Jay Herpin <[email protected]>
Signed-off-by: Greg Anderson <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
Co-authored-by: Nils-Christian Iseke <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Guillaume Doisy <[email protected]>
Co-authored-by: Sandeep Dutta <[email protected]>
Co-authored-by: Vignesh T <[email protected]>
Co-authored-by: mini-1235 <[email protected]>
Co-authored-by: Pradheep Krishna <[email protected]>
Co-authored-by: Tony Najjar <[email protected]>
Co-authored-by: Leander Stephen D'Souza <[email protected]>
Co-authored-by: Marco Bassa <[email protected]>
Co-authored-by: Raman <[email protected]>
Co-authored-by: RamanaBotta <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Tatsuro Sakaguchi <[email protected]>
Co-authored-by: Adi Vardi <[email protected]>
Co-authored-by: dw25628 <[email protected]>
Co-authored-by: Patrick Roncagliolo <[email protected]>
Co-authored-by: cboostjvisser <[email protected]>
Co-authored-by: DavidG-Develop <[email protected]>
Co-authored-by: olaghattas <[email protected]>
Co-authored-by: hutao <[email protected]>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Alberto Tudela <[email protected]>
Co-authored-by: Cihat Kurtuluş Altıparmak <[email protected]>
Co-authored-by: Sushant Chavan <[email protected]>
Co-authored-by: Tim Clephas <[email protected]>
Co-authored-by: Abhishekh Reddy <[email protected]>
Co-authored-by: ymd-stella <[email protected]>
Co-authored-by: Jay Herpin <[email protected]>
Co-authored-by: Greg Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Costmap clear around pose service

3 participants