Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 11, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses See https://github.com/ros-navigation/navigation2/pull/4873/files#r2140478819
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

  • Change max_cost default to 254

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

This is an automatic backport of pull request #5256 done by [Mergify](https://mergify.com).

Signed-off-by: Tony Najjar <[email protected]>
(cherry picked from commit 279e17e)

# Conflicts:
#	nav2_behavior_tree/plugins/condition/is_path_valid_condition.cpp
#	nav2_msgs/srv/IsPathValid.srv
@mergify
Copy link
Contributor Author

mergify bot commented Jun 11, 2025

Cherry-pick of 279e17e has failed:

On branch mergify/bp/jazzy/pr-5256
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 279e17ec.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   nav2_behavior_tree/plugins/condition/is_path_valid_condition.cpp
	both modified:   nav2_msgs/srv/IsPathValid.srv

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jun 11, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Jun 11, 2025

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-5256 branch June 11, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants