Update legate-boost with sklearn=1.6 #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
approved these changes
Dec 13, 2024
Member
jameslamb
left a comment
There was a problem hiding this comment.
I think it's totally fair at this stage in this project to only support 1 minor version of scikit-learn, agree that it doesn't have to have the same wide compatibility as XGBoost.
And this set of changes makes sense to me based on what I've experienced adding scikit-learn 1.6 support to other libraries.
Left some very very minor comments, do whatever you want with them, and I don't need to re-review.
legateboost/input_validation.py
Outdated
| return X | ||
|
|
||
|
|
||
| def lb_check_X_y(X: Any, y: Any = None) -> Any: |
Member
There was a problem hiding this comment.
Suggested change
| def lb_check_X_y(X: Any, y: Any = None) -> Any: | |
| def _lb_check_X_y(X: Any, y: Any = None) -> Any: |
I have a slight preference for prefixing this with _ to further discourage anyone from importing and relying on it, since it's really an internal implementation detail of how this project stays compatible with scikit-learn. (ref: #143)
ef4924b to
a1a71d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sklearn 1.6 is now the default on conda forge so I have updated legate-boost to use >=1.6
I've not taken the xgboost approach of continuing to support sklearn 1.5 as legate-boost does not currently have to worry about breaking changes for existing users and it would create additional work to test both in CI.
dmlc/xgboost#11021