Skip to content

Conversation

@HarrisonWAffel
Copy link
Contributor

Issue: rancher/rancher#50041

Problem

The expected format of NO_PROXY is not clearly documented, and some users are under the impression that whitespace can be included in the value. This does not align with the format expected by Go, and also results in subtle issues within the downstream cluster provisioning and upgrade process.

Solution

Update the v1 cluster validator to identify when a malformed NO_PROXY agent environment variable is provided and block create or update operations. The only time that malformed NO_PROXY values are allowed are if a cluster was previously provisioned with a NO_PROXY value which contains spaces.

CheckList

  • Test
  • Docs

@HarrisonWAffel HarrisonWAffel requested a review from a team July 2, 2025 13:56
@HarrisonWAffel HarrisonWAffel requested a review from a team as a code owner July 2, 2025 13:56
Copy link
Contributor

@jakefhyde jakefhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing nits

@HarrisonWAffel HarrisonWAffel requested a review from jakefhyde July 2, 2025 15:41
@jakefhyde jakefhyde requested a review from a team July 2, 2025 16:49
@HarrisonWAffel
Copy link
Contributor Author

latest commit updates validateHTTPNoProxyVariable to use existing utility functions from the admission package instead of returning raw admissionv1.AdmissionResponse pointers, otherwise core logic is unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants