-
Notifications
You must be signed in to change notification settings - Fork 83
Identify and block malformed NO_PROXY values #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakefhyde
requested changes
Jul 2, 2025
Contributor
jakefhyde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing nits
pkg/resources/provisioning.cattle.io/v1/cluster/validator_test.go
Outdated
Show resolved
Hide resolved
pkg/resources/provisioning.cattle.io/v1/cluster/validator_test.go
Outdated
Show resolved
Hide resolved
jakefhyde
approved these changes
Jul 2, 2025
jiaqiluo
approved these changes
Jul 2, 2025
Contributor
Author
|
latest commit updates |
…ariable, minor docs corrections
crobby
approved these changes
Jul 2, 2025
pedromfcarvalho
approved these changes
Jul 2, 2025
This was referenced Jul 7, 2025
This was referenced Jul 28, 2025
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#50041
Problem
The expected format of
NO_PROXYis not clearly documented, and some users are under the impression that whitespace can be included in the value. This does not align with the format expected by Go, and also results in subtle issues within the downstream cluster provisioning and upgrade process.Solution
Update the v1 cluster validator to identify when a malformed
NO_PROXYagent environment variable is provided and block create or update operations. The only time that malformedNO_PROXYvalues are allowed are if a cluster was previously provisioned with aNO_PROXYvalue which contains spaces.CheckList