-
Notifications
You must be signed in to change notification settings - Fork 83
Update dependency golangci/golangci-lint to v2 (main) #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0b81ff to
72e0d97
Compare
5739d10 to
b5d0352
Compare
16f295d to
f0fc5d9
Compare
f0fc5d9 to
e2300cc
Compare
e2300cc to
3027940
Compare
3027940 to
e47b128
Compare
e47b128 to
56c0d33
Compare
56c0d33 to
5d05b0e
Compare
Most of them fall in these categories: * stop ignoring returned errors from function calls * Apply deMorgan's law to complex negative boolean expressions * Delete unused local variables and struct fields * Successfully get the linter to stop complaining about uncommented global names * If one import in a block has an import prefix, all must * Deal with deprecated code * Prefer switch-blocks to if/else if/... * Remove unnecessary intermediate struct fields.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
|
||
| type tableTest struct { | ||
| wantRT func() *v3.RoleTemplate | ||
| // wantRT func() *v3.RoleTemplate //nolint:unused - can this be removed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably removable
crobby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like pretty straightforward linting stuff.
This PR contains the following updates:
v1.64.6->v2.4.0Release Notes
golangci/golangci-lint (golangci/golangci-lint)
v2.4.0Compare Source
exhaustruct: from v3.3.1 to 4.0.0 (new options:allow-empty,allow-empty-rx,allow-empty-returns,allow-empty-declarations)godox: trim filepath from report messagesstaticcheck: allow empty optionstagalign: from 1.4.2 to 1.4.3v2.3.1Compare Source
gci: from 0.13.6 to 0.13.7gosec: from 2.22.6 to 2.22.7noctx: from 0.3.5 to 0.4.0wsl: from 5.1.0 to 5.1.1v2.3.0Compare Source
ginkgolinter: from 0.19.1 to 0.20.0 (new option:force-assertion-description)iface: from 1.4.0 to 1.4.1 (report message improvements)noctx: from 0.3.4 to 0.3.5 (new detections:log/slog,exec,crypto/tls)revive: from 1.10.0 to 1.11.0 (new rule:enforce-switch-style)wsl: from 5.0.0 to 5.1.0gosec: from 2.22.5 to 2.22.6noinlineerr: from 1.0.4 to 1.0.5sloglint: from 0.11.0 to 0.11.1v2.2.2Compare Source
noinlineerr: from 1.0.3 to 1.0.4v2.2.1Compare Source
varnamelen: fix configurationv2.2.0Compare Source
arangolintlinter https://github.com/Crocmagnon/arangolintembeddedstructfieldchecklinter https://github.com/manuelarte/embeddedstructfieldchecknoinlineerrlinter https://github.com/AlwxSin/noinlineerrswaggoformatter https://github.com/golangci/swaggoswagerrcheck: addverboseoptionfuncorder: from 0.2.1 to 0.5.0 (new optionalphabetical)gomoddirectives: from 0.6.1 to 0.7.0 (new optionignore-forbidden)iface: from 1.3.1 to 1.4.0 (new optionunexported)noctx: from 0.1.0 to 0.3.3 (new report messages, and new rules related todatabase/sql)noctx: from 0.3.3 to 0.3.4 (new SQL functions detection)revive: from 1.9.0 to 1.10.0 (new rules:time-date,unnecessary-format,use-fmt-print)usestdlibvars: from 1.28.0 to 1.29.0 (new optiontime-date-month)wsl: deprecationwsl_v5: from 4.7.0 to 5.0.0 (major version with new configuration)dupword: from 0.1.3 to 0.1.6exptostd: from 0.4.3 to 0.4.4forbidigo: from 1.6.0 to 2.1.0gci: consistently format the codego-spancheck: from 0.6.4 to 0.6.5goconst: from 1.8.1 to 1.8.2gosec: from 2.22.3 to 2.22.4gosec: from 2.22.4 to 2.22.5makezero: from 1.2.0 to 2.0.1misspell: from 0.6.0 to 0.7.0usetesting: from 0.4.3 to 0.5.0path-expectstdoutwhen usingstdinand there are no changestypecheck: deduplicate errorstypecheck: stops the analysis after the first errorprint-resources-usageflaglinters.defaultsetsv2.1.6Compare Source
godot: from 1.5.0 to 1.5.1musttag: from 0.13.0 to 0.13.1v2.1.5Compare Source
Due to an error related to Snapcraft, some artifacts of the v2.1.4 release have not been published.
This release contains the same things as v2.1.3.
v2.1.4Compare Source
Due to an error related to Snapcraft, some artifacts of the v2.1.3 release have not been published.
This release contains the same things as v2.1.3.
v2.1.3Compare Source
fatcontext: from 0.7.2 to 0.8.0nakedret.max-func-lines: 0staticchecksettingsgo.modhash to the cache saltv2.1.2Compare Source
exptostd: from 0.4.2 to 0.4.3gofumpt: from 0.7.0 to 0.8.0protogetter: from 0.3.13 to 0.3.15usetesting: from 0.4.2 to 0.4.3v2.1.1Compare Source
The release process of v2.1.0 failed due to a regression inside goreleaser.
The binaries of v2.1.0 have been published, but not the other artifacts (AUR, Docker, etc.).
v2.1.0Compare Source
--path-mode=abs)${config-path})warn-unusedoption forfmtcommandfmtcommand (golangci-lint fmt --diff-colored)funcorderlinter https://github.com/manuelarte/funcordergo-errorlint: from 1.7.1 to 1.8.0 (automatic error comparison and type assertion fixes)goconst:ignore-stringsis deprecated and replaced byignore-string-valuesgoconst: from 1.7.1 to 1.8.1 (new options:find-duplicates,eval-const-expressions)govet: addhttpmuxanalyzernilnesserr: from 0.1.2 to 0.2.0 (detect more cases)paralleltest: from 1.0.10 to 1.0.14 (checks only_test.gofiles)revive: from 1.7.0 to 1.9.0 (support kebab case for setting names)sloglint: from 0.9.0 to 0.11.0 (autofix, new optionmsg-style, suggestslog.DiscardHandler)wrapcheck: from 2.10.0 to 2.11.0 (new optionreport-internal-errors)wsl: from 4.6.0 to 4.7.0 (cgo files are always excluded)fatcontext: from 0.7.1 to 0.7.2gocritic: fiximportshadowcheckergosec: from 2.22.2 to 2.22.3ireturn: from 0.3.1 to 0.4.0loggercheck: from 0.10.1 to 0.11.0nakedret: from 2.0.5 to 2.0.6nonamedreturns: from 1.0.5 to 1.0.6protogetter: from 0.3.12 to 0.3.13testifylint: from 1.6.0 to 1.6.1unconvert: update to HEADgolangci-lint-fmtpre-commit hookv2.0.2Compare Source
sourceoptionv2.0.1Compare Source
golines: fix settings during linter loadversionfield before the configurationforbidigo: fix migrationv2.0.0Compare Source
golangci-lint fmtcommand with dedicated formatter configurationgolangci-lint migratecommand to help migration from v1 to v2 (cf. Migration guide)run.relative-path-mode(cf. Migration guide)--fast-onlyflag (cf. Migration guide)linters.exclusions.warn-unusedto log a warning if an exclusion rule is unused.golinesformatter https://github.com/segmentio/golinesstaticcheck,stylecheck,gosimpleinto one linter (staticcheck) (cf. Migration guide)go-critic: from 0.12.0 to 0.13.0gomodguard: from 1.3.5 to 1.4.1 (block explicit indirect dependencies)nilnil: from 1.0.1 to 1.1.0 (new option:only-two)perfsprint: from 0.8.2 to 0.9.1 (checker name in the diagnostic message)staticcheck: newquickfixset of rulestestifylint: from 1.5.2 to 1.6.0 (new options:equal-values,suite-method-signature,require-string-msg)wsl: from 4.5.0 to 4.6.0 (new option:allow-cuddle-used-in-block)bidichk: from 0.3.2 to 0.3.3errchkjson: from 0.4.0 to 0.4.1errname: from 1.0.0 to 1.1.0funlen: fixignore-commentsoptiongci: from 0.13.5 to 0.13.6gosmopolitan: from 1.2.2 to 1.3.0inamedparam: from 0.1.3 to 0.2.0intrange: from 0.3.0 to 0.3.1protogetter: from 0.3.9 to 0.3.12unparam: from8a5130cto0df0534golangci-lint config path --jsongolangci-lint help linters --jsongolangci-lint help formatters --jsongolangci-lint linters --jsongolangci-lint formatters --jsongolangci-lint version --jsonv1.64.8Compare Source
v1.64.7Compare Source
depguard: from 2.2.0 to 2.2.1dupl: from3e9179atof665c8dgosec: from 2.22.1 to 2.22.2staticcheck: from 0.6.0 to 0.6.1Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.