Add k8s 1.30 support #412
Merged
Add k8s 1.30 support #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9794cb7 to
40a2939
Compare
b8c87b1 to
2cdbe51
Compare
Comment on lines
+8
to
+32
| k8s.io/api => k8s.io/api v0.30.1 | ||
| k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.30.1 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.30.1 | ||
| k8s.io/apiserver => k8s.io/apiserver v0.30.1 | ||
| k8s.io/cli-runtime => k8s.io/cli-runtime v0.30.1 | ||
| k8s.io/client-go => k8s.io/client-go v0.30.1 | ||
| k8s.io/cloud-provider => k8s.io/cloud-provider v0.30.1 | ||
| k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.30.1 | ||
| k8s.io/code-generator => k8s.io/code-generator v0.30.1 | ||
| k8s.io/component-helpers => k8s.io/component-helpers v0.30.1 | ||
| k8s.io/controller-manager => k8s.io/controller-manager v0.30.1 | ||
| k8s.io/cri-api => k8s.io/cri-api v0.30.1 | ||
| k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.30.1 | ||
| k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.30.1 | ||
| k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.30.1 | ||
| k8s.io/kube-proxy => k8s.io/kube-proxy v0.30.1 | ||
| k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.30.1 | ||
| k8s.io/kubectl => k8s.io/kubectl v0.30.1 | ||
| k8s.io/kubelet => k8s.io/kubelet v0.30.1 | ||
| k8s.io/kubernetes => k8s.io/kubernetes v1.30.1 | ||
| k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.30.1 | ||
| k8s.io/metrics => k8s.io/metrics v0.30.1 | ||
| k8s.io/mount-utils => k8s.io/mount-utils v0.30.1 | ||
| k8s.io/pod-security-admission => k8s.io/pod-security-admission v0.30.1 | ||
| k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.30.1 |
Contributor
There was a problem hiding this comment.
Looks like the latest 1.30 version is now v0.30.2, perhaps we may want to bump modules to that.
Contributor
There was a problem hiding this comment.
Looks like Rancher uses 0.30.1: rancher/rancher@f138213. I'd prefer we stay in step with Rancher, so let's keep 0.30.1.
MbolotSuse
reviewed
Jun 27, 2024
2cdbe51 to
5baaa07
Compare
MbolotSuse
approved these changes
Jun 27, 2024
ericpromislow
approved these changes
Jun 27, 2024
Contributor
ericpromislow
left a comment
There was a problem hiding this comment.
LGTM, +1 on bumping to the next minor version later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#45331
Problem
We need 1.30 k8s support in webhook
Solution
CheckList