Add validation to not admit RoleTemplates with both context=cluster & ProjectCreatorDefault=true #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a9801f to
9eaa18d
Compare
bigkevmcd
reviewed
Mar 25, 2024
Contributor
bigkevmcd
left a comment
There was a problem hiding this comment.
While I think the actual fix is fine, I think we can improve the tests to clarify that they're testing.
JonCrowther
reviewed
Mar 27, 2024
pkg/resources/management.cattle.io/v3/roletemplate/validator.go
Outdated
Show resolved
Hide resolved
bigkevmcd
reviewed
Mar 28, 2024
… ProjectCreatorDefault=true Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
Signed-off-by: Vatsal Parekh <[email protected]>
d9f1686 to
9d7db6b
Compare
Signed-off-by: Vatsal Parekh <[email protected]>
JonCrowther
approved these changes
Apr 2, 2024
bigkevmcd
approved these changes
Apr 2, 2024
Contributor
bigkevmcd
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Add validation to not admit RoleTemplates with both context=cluster & ProjectCreatorDefault=true
Problem
SURE-7635
Solution
Add a check for this field in validation
CheckList