-
Notifications
You must be signed in to change notification settings - Fork 83
Bump bci/golang from 1.17-17.62 to 1.17-29.1 #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps bci/golang from 1.17-17.62 to 1.17-29.1. --- updated-dependencies: - dependency-name: bci/golang dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
macedogm
approved these changes
Aug 19, 2022
pmatseykanets
pushed a commit
to pmatseykanets/webhook
that referenced
this pull request
Jun 11, 2024
…#102) * Allow Restricted Admin to update external-rules feature flag * Check old value to see if feature is enabled * defaults to *,*,* for other different than enabling * only check for value changes * Add test * Move isUpdateAllowed to happen first * improve error message --------- Co-authored-by: Jonathan Crowther <[email protected]>
pmatseykanets
added a commit
that referenced
this pull request
Jun 11, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 18, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 18, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 18, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
raulcabello
added a commit
that referenced
this pull request
Jun 19, 2024
* [v0.4.6] s4: Fixes 374 (#392) * Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]> * bump rancher to commit 2145c8e9d6034579caa6279856c59679f1102cf3 --------- Co-authored-by: Peter Matseykanets <[email protected]>
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 21, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
raulcabello
added a commit
to raulcabello/webhook
that referenced
this pull request
Jun 24, 2024
* Update rancher/rancher/pkg/apis dependency * Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (rancher#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]>
raulcabello
added a commit
that referenced
this pull request
Jun 25, 2024
* Verify ExternalRules in RoleTemplates If the feature flag external-rules is enabled, the validation for RT follows this sequence: - 1) Reject if externalRules are provided and the user doesn’t have escalate permissions on RoleTemplates. - 2) Validate the policy rules defined in externalRules the same way as the already existing rules field. This validation leverages Kubernetes’ upstream validation. Webhook will validate this only if external is set to true. - 3) Use externalRules for resolving rules if provided. - 4) Use backing ClusterRole in the local cluster if externalRules are not provided. - 5) Reject if externalRules are not provided and there is no backing ClusterRole in the local cluster. For PRTB or CRTB: - 1) Use externalRules for resolving rules if provided. - 2) Use backing ClusterRole in the local cluster if externalRules are not provided. The previous verification process applies if the external-rules feature flag is disabled. * Allow Restricted Admin to update external-rules feature flag (#102) --------- Co-authored-by: Raul Cabello Martin <[email protected]> Co-authored-by: Jonathan Crowther <[email protected]> * bump rancher to be able to use ExternalRules * fix test conflict --------- Co-authored-by: Peter Matseykanets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps bci/golang from 1.17-17.62 to 1.17-29.1.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)