Use rancher/wharfie code shared with k3s for for bootstrap #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweomer
approved these changes
May 12, 2021
briandowns
approved these changes
May 12, 2021
Moves the runtime image bootstrap to after config has been pulled from the server, so that we can promote --system-default-registry to a server var, like --cluster-dns and other things that should be set the same on all nodes. With this change we no longer drop manifests for packaged components on agents, which never made use of them anyway.
Contributor
|
Includes a fix for #1019 |
This was referenced May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Removal of --system-default-registry from agent flags should be called out in release notes, and removed from docs.
Types of Changes
Verification
Linked Issues
For #958 and #959
Further Comments