Skip to content

Use released rancher-turtles-providers chart for dev=false #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
valaparthvi merged 1 commit into from
Jan 13, 2026
Merged

Use released rancher-turtles-providers chart for dev=false #385

valaparthvi merged 1 commit into from
Jan 13, 2026
+124 −73

Conversation

@valaparthvi
Copy link
Collaborator

@valaparthvi valaparthvi commented Jan 6, 2026 •
edited
Loading

What does this PR do?

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #383

Checklist:

  • Squashed commits into logical changes - this will be done before merging
  • Documentation
  • GitHub Actions (if applicable)
Version dev Test Status Link
2.13 true upgrade 🟢 [3158] Rancher-head/2.13 - @install @upgrade destroy=true dev=true
2.13 false upgrade 🟢 [3154] Rancher-head/2.13 - @install @upgrade destroy=true dev=false
head/2.13 true short 🟠 [3160] Rancher-head/2.13 - @install @short destroy=true dev=true
head/2.13 false short 🟠 [3161] Rancher-head/2.13 - @install @short destroy=true dev=false
latest/2.12.3 true short 🟢 [3165] Rancher-latest/2.12.3 - @install @short destroy=true dev=true
latest/2.12.3 false install 🟢 [3166] Rancher-latest/2.12.3 - @install destroy=true dev=false
prime/2.13.1 true short 🟢 [3167] Rancher-prime/2.13.1 - @install @short destroy=true dev=true
prime/2.13.1 false short 🟢 [3168] Rancher-prime/2.13.1 - @install @short destroy=true dev=false
pime/2.12.5 true install 🟢 [3169] Rancher-prime/2.12.5 - @install destroy=true dev=true
prime/2.12.5 false install 🟢 [3170] Rancher-prime/2.12.5 - @install destroy=true dev=false
head/2.13 true vsphere 🟠 [3180] Rancher-head/2.13 - @install @vsphere destroy=true dev=true

Special notes for your reviewer:

@valaparthvi valaparthvi force-pushed the release-turtles-providers-chart branch 2 times, most recently from cb939cf to 87fa4c2 Compare January 7, 2026 15:15
valaparthvi
valaparthvi commented Jan 7, 2026
View reviewed changes
.github/workflows/master-e2e.yaml
echo "TURTLES_BRANCH=release-0.24" >> ${GITHUB_ENV}
fi
- name: Check out rancher/turtles repo
if: ${{ inputs.turtles_dev_chart == true || contains(env.RANCHER_VERSION, '2.13') }}
Copy link
Collaborator Author

@valaparthvi valaparthvi Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Majority of the changes are reverted from https://github.com/rancher/rancher-turtles-e2e/pull/314/changes, since we do not need to build providers chart all the time anymore.

@valaparthvi valaparthvi force-pushed the release-turtles-providers-chart branch 2 times, most recently from 0961657 to ada83ae Compare January 9, 2026 12:30
@valaparthvi valaparthvi marked this pull request as ready for review January 9, 2026 15:50
cpinjani
cpinjani approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@cpinjani cpinjani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@valaparthvi valaparthvi force-pushed the release-turtles-providers-chart branch from ada83ae to f779a66 Compare January 12, 2026 09:04
@valaparthvi
Copy link
Collaborator Author

valaparthvi commented Jan 12, 2026 •
edited
Loading

[3184] Rancher-prime/2.12.5 - @install @short destroy=true dev=false 🟢
[3183] Rancher-head/2.13 - @install @short destroy=true dev=true 🟢
[3182] Rancher-head/2.13 - @install @upgrade destroy=true dev=true 🟢
[3181] Rancher-head/2.13 - @install @upgrade destroy=true dev=false 🔴

---- After fix -----
https://github.com/rancher/rancher-turtles-e2e/actions/runs/20923810625/job/60116214079 🟢

@valaparthvi valaparthvi force-pushed the release-turtles-providers-chart branch from 2e85f96 to 10ef6e5 Compare January 13, 2026 08:56
@valaparthvi
Copy link
Collaborator Author

valaparthvi commented Jan 13, 2026 •
edited
Loading

[3204] Rancher-head/2.13 - @install @upgrade destroy=true dev=false 🟢

[3205] Rancher-head/2.13 - @install @upgrade destroy=true dev=true 🟢

@valaparthvi valaparthvi merged commit 00540e1 into main Jan 13, 2026
18 of 19 checks passed
@valaparthvi valaparthvi deleted the release-turtles-providers-chart branch January 13, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpinjani cpinjani cpinjani approved these changes

@thehejik thehejik Awaiting requested review from thehejik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use released rancher-turtles-providers chart for dev=false

4 participants

@valaparthvi @thehejik @cpinjani