Skip to content

Conversation

@enrichman
Copy link
Collaborator

Fix #584

When the Kubernetes version was specified in the Cluster spec we were not checking the Kubernetes host version.
Because of this the check for the Cluster reconciliation from the k3kcli was failing, when trying to create a virtual cluster with the version specified.

This PR will check the Kubernetes host version even when the virtual cluster version is specified, the behavior will be the same though. A new K3sVersion func was added, because it will be probably useful in other circumstances (see #571 (review)).

This PR will also fix #583

@enrichman enrichman self-assigned this Dec 2, 2025
@enrichman enrichman added this to the 1.0.1 milestone Dec 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.78%. Comparing base (5c49c3d) to head (8412e06).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   58.75%   58.78%   +0.02%     
==========================================
  Files          56       56              
  Lines        5315     5316       +1     
==========================================
+ Hits         3123     3125       +2     
  Misses       1900     1900              
+ Partials      292      291       -1     
Flag Coverage Δ
cli 53.66% <90.90%> (+0.67%) ⬆️
controller 57.01% <90.90%> (+0.03%) ⬆️
e2e 57.01% <90.90%> (+0.03%) ⬆️
unit 35.97% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman merged commit e385ceb into rancher:main Dec 3, 2025
11 of 12 checks passed
@enrichman enrichman deleted the 584-fix-host-version branch December 3, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

k3kcli create command throwing error The Host version is showing the k3s version instead of the plain Kubernetes one

3 participants