Skip to content

Conversation

@galal-hussein
Copy link
Collaborator

This PR will change how we create pseudo (fake) PVs to allow the scheduling of the pods that claims a PVC, instead of the previous behavior of creating a fake PV only when a consumer Pod is created, we now will create/delete the fake PV whenever the PVC is created/delete on the virtual cluster, this will eliminate errors/bugs like scaling down deployments and random deletion of the pods in virtual cluster.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.57%. Comparing base (5c49c3d) to head (d65de0d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ubelet/controller/syncer/persistentvolumeclaims.go 87.50% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   58.75%   60.57%   +1.81%     
==========================================
  Files          56       55       -1     
  Lines        5315     5293      -22     
==========================================
+ Hits         3123     3206      +83     
+ Misses       1900     1795     -105     
  Partials      292      292              
Flag Coverage Δ
cli 53.38% <ø> (+0.39%) ⬆️
controller 57.12% <ø> (+0.13%) ⬆️
e2e 57.12% <ø> (+0.13%) ⬆️
unit 37.62% <87.50%> (+1.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, I left a couple of comments!

I know other controllers in the syncer package have the same logging issue, but let's at least use the right level in this PR.

In the #581 I tried to centralize the create/update (and the logging) for some of them but it looks it didn't work as expected. I haven't investigated.

Signed-off-by: galal-hussein <[email protected]>
Copy link
Collaborator

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@galal-hussein galal-hussein merged commit 0086d5a into rancher:main Dec 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants