-
Notifications
You must be signed in to change notification settings - Fork 58
Attach creation of Pseudo PV to the PVC instead of the pods #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach creation of Pseudo PV to the PVC instead of the pods #577
Conversation
Signed-off-by: galal-hussein <[email protected]>
Signed-off-by: galal-hussein <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 58.75% 60.57% +1.81%
==========================================
Files 56 55 -1
Lines 5315 5293 -22
==========================================
+ Hits 3123 3206 +83
+ Misses 1900 1795 -105
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
enrichman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, I left a couple of comments!
I know other controllers in the syncer package have the same logging issue, but let's at least use the right level in this PR.
In the #581 I tried to centralize the create/update (and the logging) for some of them but it looks it didn't work as expected. I haven't investigated.
Signed-off-by: galal-hussein <[email protected]>
d98062f to
fe06436
Compare
Signed-off-by: galal-hussein <[email protected]>
enrichman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR will change how we create pseudo (fake) PVs to allow the scheduling of the pods that claims a PVC, instead of the previous behavior of creating a fake PV only when a consumer Pod is created, we now will create/delete the fake PV whenever the PVC is created/delete on the virtual cluster, this will eliminate errors/bugs like scaling down deployments and random deletion of the pods in virtual cluster.
sharedmode #574