Skip to content

Conversation

@enrichman
Copy link
Collaborator

This PR fixes the error from the Virtual Kubelet trying to create Events without the needed RBAC:

2025-11-21T16:53:19.228Z    ERROR    Server rejected event (will not retry!)    {"event": {"namespace": "ns-dg96l", "name": "cluster-b9k9s.187a13d2948bb5ac"}, "error": "events is forbidden: User \"system:serviceaccount:ns-dg96l:k3k-cluster-b9k9s-kubelet\" cannot create resource \"events\" in API group \"\" in the namespace \"ns-dg96l\""}

It also cleanup the virtual kubelet logs, in order to have a more consistent flow with the same structured values, and logs in the errors.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 3.20000% with 121 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.79%. Comparing base (521ff17) to head (21fe932).

Files with missing lines Patch % Lines
k3k-kubelet/provider/provider.go 0.00% 121 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
- Coverage   59.27%   58.79%   -0.49%     
==========================================
  Files          56       56              
  Lines        5255     5315      +60     
==========================================
+ Hits         3115     3125      +10     
- Misses       1846     1899      +53     
+ Partials      294      291       -3     
Flag Coverage Δ
cli 53.57% <100.00%> (+0.47%) ⬆️
controller 56.88% <100.00%> (+0.04%) ⬆️
e2e 56.88% <100.00%> (+0.04%) ⬆️
unit 36.02% <3.20%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman self-assigned this Nov 25, 2025
@enrichman enrichman merged commit 5c49c3d into rancher:main Nov 25, 2025
9 checks passed
@enrichman enrichman deleted the fix-create-events-rbac branch November 25, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants