Skip to content

Conversation

@enrichman
Copy link
Collaborator

@enrichman enrichman commented Nov 21, 2025

#441 fixed an issue about a CreateContainerConfigError coming from an invalid VolumeMount.
Creating a Pod that is erroring and then trying to fix it updating the annotation was not working.

This PR just adds a test to avoid regressions, while trying to fix #495.

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.31%. Comparing base (8856419) to head (658a568).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   59.61%   59.31%   -0.31%     
==========================================
  Files          56       56              
  Lines        5255     5255              
==========================================
- Hits         3133     3117      -16     
- Misses       1837     1845       +8     
- Partials      285      293       +8     
Flag Coverage Δ
cli 53.35% <ø> (-0.08%) ⬇️
controller 56.78% <ø> (-0.36%) ⬇️
e2e 56.78% <ø> (-0.36%) ⬇️
unit 36.32% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman merged commit 521ff17 into rancher:main Nov 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permission issue with ingress installation

3 participants