Fixed panic during kubeconfig generate #554
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
+ Coverage 59.58% 59.67% +0.09%
==========================================
Files 56 56
Lines 5151 5158 +7
==========================================
+ Hits 3069 3078 +9
- Misses 1798 1799 +1
+ Partials 284 281 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| if len(k3kService.Spec.Ports) == 0 { | ||
| logrus.Warn("No exposed port in LoadBalancer service.") |
There was a problem hiding this comment.
Should this be a different message from the one above?
There was a problem hiding this comment.
Do you mean that it could be the same message, like "No exposed ports in service."?
I'm not even sure you can have a Service without a Port actually.
There was a problem hiding this comment.
Oops...should've clarified this, you can't have a Service without a Port, spec.ports is a required value.
There was a problem hiding this comment.
Ah, awesome. So should I drop the check altogether? I'm fine with this, it simplify the code, and it was not really the reason of the PR. 🙂
Fix #432
When a Cluster is exposed with a LoadBalancer but the IP is not yet issued the Status of the Service is empty, because the ExternalIP is still in a
<pending>state.This PR adds a check, and logs a warning.