Skip to content

Conversation

@enrichman
Copy link
Collaborator

@enrichman enrichman commented Nov 10, 2025

The Conformance tests for the shared mode are failing (we know that), but it was hard to see how many of them, and which one.

This PR adds a Job Summary with a markdown table showing which tests are failing:

image image

See run: https://github.com/enrichman/k3k/actions/runs/19249567094

It also drops the job to run the sigs test, that was not really used.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.73%. Comparing base (a84c49f) to head (debf097).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   59.58%   59.73%   +0.15%     
==========================================
  Files          56       56              
  Lines        5151     5151              
==========================================
+ Hits         3069     3077       +8     
+ Misses       1798     1794       -4     
+ Partials      284      280       -4     
Flag Coverage Δ
cli 53.67% <ø> (+0.54%) ⬆️
controller 58.40% <ø> (-0.06%) ⬇️
e2e 58.40% <ø> (-0.06%) ⬇️
unit 41.57% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman changed the title [WIP] simplify shared conformance tests Add Job Summary reports to Conformance tests Nov 11, 2025
@enrichman enrichman marked this pull request as ready for review November 11, 2025 10:45
@enrichman enrichman self-assigned this Nov 11, 2025
@enrichman enrichman merged commit de0d2a0 into rancher:main Nov 11, 2025
9 checks passed
@enrichman enrichman deleted the simplify-conformance-shared branch November 11, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants