Skip to content

Conversation

@enrichman
Copy link
Collaborator

Now that is possible to run the tests against an external cluster we have found some issues.

I.e. we were making the assumption to have a single node clusters, or that we have always a "clean" installation.

This PR fixes the issues, cleaning up also some leftover namespaces, and improved the download of the coverage data.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.67%. Comparing base (af9e1d6) to head (4d910a4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   59.61%   59.67%   +0.05%     
==========================================
  Files          56       56              
  Lines        5151     5151              
==========================================
+ Hits         3071     3074       +3     
+ Misses       1797     1796       -1     
+ Partials      283      281       -2     
Flag Coverage Δ
cli 53.26% <ø> (-0.11%) ⬇️
controller 58.56% <ø> (+0.10%) ⬆️
e2e 58.56% <ø> (+0.10%) ⬆️
unit 41.50% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman requested review from JonCrowther, bigkevmcd, jp-gouin and raulcabello and removed request for JonCrowther and jp-gouin October 30, 2025 17:55
Copy link

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@enrichman enrichman merged commit 2e6de51 into rancher:main Oct 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants