Skip to content

Conversation

@enrichman
Copy link
Collaborator

@enrichman enrichman commented Oct 23, 2025

This PR cleanup the spec of the sync field, and fix a couple of missing camel case for the configMaps and loadBalancer.

It add the default for the "false" struct to avoid the current status:

expose:
  loadbalancer: {}
sync:
  configmaps:
    enabled: true
  ingresses: {}
  persistentVolumeClaims:
    enabled: true
  priorityClasses: {}
  secrets:
    enabled: true
  services:
    enabled: true

Now the spec will be created with also the false fields:

expose:
  loadBalancer: {}
sync:
  configMaps:
    enabled: true
  ingresses:
    enabled: false
  persistentVolumeClaims:
    enabled: true
  priorityClasses:
    enabled: false
  secrets:
    enabled: true
  services:
    enabled: true

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.87%. Comparing base (cebf659) to head (bc0849c).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   59.60%   54.87%   -4.74%     
==========================================
  Files          56       56              
  Lines        5132     5132              
==========================================
- Hits         3059     2816     -243     
- Misses       1801     2054     +253     
+ Partials      272      262      -10     
Flag Coverage Δ
cli 53.70% <ø> (+0.57%) ⬆️
controller 51.48% <ø> (-6.92%) ⬇️
e2e 51.48% <ø> (-6.92%) ⬇️
unit 41.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman changed the title Updated Cluster spec for sync and loadbalancer Updated Cluster and VirtualClusterPolicy spec for sync and loadbalancer Oct 24, 2025
@enrichman enrichman self-assigned this Oct 24, 2025
@bigkevmcd
Copy link

Can you fix the examples so that they will cleanly apply?

@enrichman enrichman merged commit bf70e0d into rancher:main Oct 24, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants