Cleanup of customCAs spec

[enrichman]

Moving customCAs field to be a pointer. This will avoid creating an empty struct by default, when not needed:

apiVersion: k3k.io/v1alpha1
kind: Cluster
metadata:
  name: foo
  namespace: k3k-foo
spec:
  customCAs:
    sources:
      clientCA: {}
      etcdPeerCA: {}
      etcdServerCA: {}
      requestHeaderCA: {}
      serverCA: {}
      serviceAccountToken: {}

Also moving the enabled to true as default, and the secretName as a required field.

This will result in not having the customCAs if not provided, and force the user providing the secretName.

This way the validateCustomCACerts check should not be needed, but...

Result:

apiVersion: k3k.io/v1alpha1
kind: Cluster
metadata:
  name: foo
  namespace: k3k-foo
spec:
  customCAs:
    enabled: true
    sources:
      clientCA:
        secretName: foo
      etcdPeerCA:
        secretName: foo
      etcdServerCA:
        secretName: foo
      requestHeaderCA:
        secretName: foo
      serverCA:
        secretName: foo
      serviceAccountToken:
        secretName: foo

[codecov-commenter]

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.43%. Comparing base (ee7eac8) to head (8209a01).

Files with missing lines	Patch %	Lines
pkg/controller/cluster/cluster.go	0.00%	2 Missing and 1 partial ⚠️
pkg/controller/cluster/server/server.go	33.33%	1 Missing and 1 partial ⚠️
cli/cmds/cluster_create.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
+ Coverage   58.63%   59.43%   +0.79%     
==========================================
  Files          56       56              
  Lines        6634     5132    -1502     
==========================================
- Hits         3890     3050     -840     
+ Misses       2472     1805     -667     
- Partials      272      277       +5     

Flag	Coverage Δ
cli	53.07% <0.00%> (+1.14%)	⬆️
controller	58.13% <45.45%> (+1.43%)	⬆️
e2e	58.13% <45.45%> (+1.43%)	⬆️
unit	41.70% <0.00%> (+0.97%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pmatseykanets]

Overall looks reasonable.

[pmatseykanets]

Seems to be unnecessary given the conditional on L333.

[enrichman]

Yes, that's true. I just wanted to be extra safe in case someone calls this method and forgets to check that. :)

[pmatseykanets]

This can be

Suggested change

	sortedCertIDs = slices.Sorted(maps.Keys(caCertMap))

[pmatseykanets]

On a different note is there any reason why it should be sorted? If yes is there any reason not to pre-sort it as it's hardcoded?