Skip to content

Conversation

@enrichman
Copy link
Collaborator

When creating the Nginx Pod used in our tests we were not waiting for it to be in the Ready state.

This was causing an issue during the tests in virtual mode, because it's status was not being correctly checked.
This PR check the Pod status, and split the check to be more resilient.

It also has many changes because of a couple of import changes:

"k8s.io/api/core/v1":                      corev1 -> v1
"k8s.io/apimachinery/pkg/apis/meta/v1":    v1 -> metav1

@enrichman enrichman force-pushed the fix-flaky-test-virtual-mode branch from a50fe59 to 2feff91 Compare October 21, 2025 10:56
@enrichman enrichman requested a review from jp-gouin October 21, 2025 11:09
@enrichman enrichman self-assigned this Oct 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.39%. Comparing base (730e4e1) to head (6b12b60).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   53.73%   58.39%   +4.65%     
==========================================
  Files          56       56              
  Lines        6578     6578              
==========================================
+ Hits         3535     3841     +306     
+ Misses       2774     2462     -312     
- Partials      269      275       +6     
Flag Coverage Δ
cli 51.52% <ø> (-0.44%) ⬇️
controller 56.73% <ø> (+6.66%) ⬆️
e2e 56.73% <ø> (+6.66%) ⬆️
unit 40.71% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@jp-gouin jp-gouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enrichman enrichman merged commit 514fdf6 into rancher:main Oct 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants