Skip to content

Conversation

@enrichman
Copy link
Collaborator

The nginxPod was not updated during the periodic fetch, and this was causing to check for its original/old conditions, causing it to fails.

This PR also fixes the dumpK3kCoverageData to be more resilient, checking the Ready condition of the Pod, instead of the Phase.

@enrichman enrichman self-assigned this Oct 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.14%. Comparing base (8ffdc9b) to head (7f5e89c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          56       56           
  Lines        6559     6559           
=======================================
  Hits         3748     3748           
  Misses       2545     2545           
  Partials      266      266           
Flag Coverage Δ
cli 51.38% <ø> (-0.77%) ⬇️
controller 58.28% <ø> (+0.24%) ⬆️
e2e 58.28% <ø> (+0.24%) ⬆️
unit 40.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman merged commit 7644406 into rancher:main Oct 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants