-
Notifications
You must be signed in to change notification settings - Fork 59
Fix extraEnv and other Helm values
#500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
+ Coverage 50.63% 57.09% +6.46%
==========================================
Files 56 56
Lines 6559 6559
==========================================
+ Hits 3321 3745 +424
+ Misses 2970 2547 -423
+ Partials 268 267 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charts/k3k/templates/deployment.yaml
Outdated
| - --shared-agent-image={{- include "agent.shared.registry" .}}{{ .Values.agent.shared.image.repository }}:{{ default .Chart.AppVersion .Values.agent.shared.image.tag }} | ||
| - --shared-agent-image-pull-policy={{ .Values.agent.shared.image.pullPolicy }} | ||
| - --virtual-agent-image={{- include "agent.virtual.registry" .}}{{ .Values.agent.virtual.image.repository }} | ||
| - --virtual-agent-image-pull-policy={{ .Values.agent.virtual.image.pullPolicy }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a look at this I see the Helm values and the flags/envs are "swapped":
virtual-agent-imageagent.virtual.image
Seeing them all together is probably more natural to have the "convention" we used with Helm:
agent > virtual > image
What do you think about changing them?
| - --shared-agent-image={{- include "agent.shared.registry" .}}{{ .Values.agent.shared.image.repository }}:{{ default .Chart.AppVersion .Values.agent.shared.image.tag }} | |
| - --shared-agent-image-pull-policy={{ .Values.agent.shared.image.pullPolicy }} | |
| - --virtual-agent-image={{- include "agent.virtual.registry" .}}{{ .Values.agent.virtual.image.repository }} | |
| - --virtual-agent-image-pull-policy={{ .Values.agent.virtual.image.pullPolicy }} | |
| - --agent-shared-image={{- include "agent.shared.registry" .}}{{ .Values.agent.shared.image.repository }}:{{ default .Chart.AppVersion .Values.agent.shared.image.tag }} | |
| - --agent-shared-image-pull-policy={{ .Values.agent.shared.image.pullPolicy }} | |
| - --agent-virtual-image={{- include "agent.virtual.registry" .}}{{ .Values.agent.virtual.image.repository }} | |
| - --agent-virtual-image-pull-policy={{ .Values.agent.virtual.image.pullPolicy }} |
This PR fixes #498 and refactor/change some helm values.
resourcesis now defined as a plain object`replicaCountrenamed toreplicasas in the specAlso renamed 4 flags for the K3k controller to match the hierarchy used in the Helm values: