Skip to content

Conversation

@enrichman
Copy link
Collaborator

Fix #496 by checking that the Services owned by the Cluster are resources within the virtual cluster.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.07%. Comparing base (9f265c7) to head (a0170c0).

Files with missing lines Patch % Lines
pkg/controller/cluster/service.go 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   54.15%   54.07%   -0.08%     
==========================================
  Files          56       56              
  Lines        6552     6559       +7     
==========================================
- Hits         3548     3547       -1     
- Misses       2736     2747      +11     
+ Partials      268      265       -3     
Flag Coverage Δ
cli 51.95% <50.00%> (+0.25%) ⬆️
controller 53.66% <50.00%> (-0.25%) ⬇️
e2e 53.66% <50.00%> (-0.25%) ⬇️
unit 40.79% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman force-pushed the 496-fix-service-reconcile branch from 134f940 to d70e4c3 Compare October 8, 2025 10:51
@enrichman enrichman force-pushed the 496-fix-service-reconcile branch from d70e4c3 to ae563da Compare October 8, 2025 11:20
@enrichman enrichman force-pushed the 496-fix-service-reconcile branch from 3dc53b7 to a0170c0 Compare October 8, 2025 11:23
@enrichman enrichman merged commit 7387fc1 into rancher:main Oct 8, 2025
6 checks passed
@enrichman enrichman deleted the 496-fix-service-reconcile branch October 8, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while trying to reconcile Cluster owned services

3 participants