Skip to content

Conversation

@enrichman
Copy link
Collaborator

This PR fixes #468 when deleting a server with a name that contains a - was not handled properly.

The Cluster name is now fetched from the owner of the StatefulSet.

@enrichman enrichman self-assigned this Oct 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 50.66667% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.18%. Comparing base (5c95ca3) to head (2e928ee).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/cluster/statefulset.go 49.31% 31 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   54.04%   54.18%   +0.13%     
==========================================
  Files          56       56              
  Lines        6528     6554      +26     
==========================================
+ Hits         3528     3551      +23     
- Misses       2734     2739       +5     
+ Partials      266      264       -2     
Flag Coverage Δ
cli 51.68% <42.66%> (+0.21%) ⬆️
controller 54.01% <50.66%> (+0.20%) ⬆️
e2e 54.01% <50.66%> (+0.20%) ⬆️
unit 40.67% <2.66%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@enrichman enrichman force-pushed the 468-ha-server-deletion branch from 8eb1d58 to d3609c8 Compare October 3, 2025 14:46
@enrichman enrichman merged commit 9f265c7 into rancher:main Oct 8, 2025
6 checks passed
@enrichman enrichman deleted the 468-ha-server-deletion branch October 8, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug HA failure

3 participants