2.13 ::: backport PRs 16203, 16225 and 16208 #16292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16262
Backport PR #16203
Backport PR #16225
Backport PR #16208
Occurred changes and/or fixed issues
Make it so we can now differentiate between detail pages and show configuration when adding tabs via extensions.
add new locations for Tab extension point:
TabLocation. RESOURCE_SHOW_CONFIGURATION
TabLocation.RESOURCE_DETAIL_PAGE
TabLocation.RESOURCE_CREATE_PAGE
TabLocation.RESOURCE_EDIT_PAGE
TabLocation.ALL
fix bug with adding tabs from extensions on workloads edit/create views
Technical notes summary
Areas or cases that should be tested
Create
MyTabComponentin the root folder of thepkg/kubectl-explainbuiltin extensionadd the following bits of code to the same file:
SHOW CONFIGURATION
DETAIL PAGE
CREATE PAGE
EDIT PAGE
ALL PAGES
Areas which could experience regressions
Screenshot/Video
Checklist
Admin,Standard UserandUser Base