Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Dec 24, 2025

Summary

This suppresses the missing template warning by using a render function to generate a valid vnode.

Fixes #16236

Occurred changes and/or fixed issues

  • Suppress missing template warning

Technical notes summary

The render function with a valid v-node technically renders a div. This shouldn't have an effect on the rendered output of the component since the beforeCreate() hook acts as a router guard to update the route before anything renders to the page.

I considered moving the entirety of the logic into shell/config/router/routes.js, but the reliance on the store has carries more risk for regression.

Areas or cases that should be tested

Navigate to the settings page. Warning should be suppressed and the page renders as expected.

Areas which could experience regressions

This could technically render a page with an empty div in the setting page if the routing fails, but this would not be any different from the existing behavior.

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rak-phillip rak-phillip merged commit 6d7f834 into rancher:master Dec 24, 2025
81 of 93 checks passed
@rak-phillip rak-phillip deleted the task/16236-settings branch December 24, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console Warning: [Vue warn]: Component is missing template or render function

2 participants