Display search results if the dropdown is closed #16272
Merged
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This forces the SelectPrincipal dropdown to display search results if the dropdown has been closed for any reason.
Fixes #16246
Occurred changes and/or fixed issues
Technical notes summary
There are situations where the dropdown can be closed while a user might want to search for a principal, see #16246 for one those cases. This forces the dropdown to reopen when results exist.
Alternatively, we can always force it to open when a search term is applied.
I attempted to prevent the dropdown from closing on click, but there were too many edge cases where the it could still actually close. I found this initial solution to be overly complex and have opted for allowing the dropdown to close and forcing it to open again instead.
Areas or cases that should be tested
Follow the repro steps in the associated issue. Ensure that the results are displayed after typing. Ensure that the results can be selected via mouse and keyboard.
Areas which could experience regressions
There's a possibility that keyboard navigation and selection could be affected. I think this risk is small.
Screenshot/Video
NA
Checklist
Admin,Standard UserandUser Base