Skip to content

Conversation

@marcelofukumoto
Copy link
Contributor

@marcelofukumoto marcelofukumoto commented Dec 18, 2025

Summary

Fixes #15961

Occurred changes and/or fixed issues

  • Copied implementation from gitops to helmops

shell/edit/fleet.cattle.io.helmop.vue - Changed just the registerBeforeHook and added the condition to only execute whenever is created to add the current user id
shell/edit/tests/fleet.cattle.io.helmop.test.ts - Added new tests to verify the integrity of the registerBeforeHook and the function as well that has been created, specially to see if _EDIT and _CREATE is properly separated

Technical notes summary

  • Copied same functionality from gitops
  • Make sure the data doesnt change on edit, specially for new users
  • Make sure the data is added correctly on creation

Areas or cases that should be tested

  • Only HELMOPS is affected for any cases
  • Nothing on the screen to show the information, just data

Areas which could experience regressions

  • Only HELMOPS is affected
  • Regression could happen for places where the data is used and not mapped properly

Screenshot/Video

PDF with the Test Cases and screenshot
Test Cases 15961.pdf

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@marcelofukumoto marcelofukumoto merged commit 19485e9 into rancher:master Dec 22, 2025
104 of 119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add created-by-user-id label to the HelmOps created resources.

2 participants