Skip to content

Conversation

@eva-vashkevich
Copy link
Member

@eva-vashkevich eva-vashkevich commented Dec 18, 2025

Summary

Fixes #13472

Waiting status is a special case, which was not considered by our existing logic, so we were not correclt identifying such cluster as imported.

Occurred changes and/or fixed issues

Added a new special condition to cover missed case.

Technical notes summary

Areas or cases that should be tested

  1. Import a k3s or rke2 cluster
  2. When the State changes to "Waiting", attempt to Edit Config
  3. Imported cluster edit should open, no ember should be loaded

Areas which could experience regressions

Imported hosted providers and provisioned rke2/k3s clusters could be affected.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this fine for types like custom?

@eva-vashkevich
Copy link
Member Author

@richard-cox I've tried provisioning a custom cluster and didn't notice any regressions

Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I verified that the correct edit page is loaded, and the table 'Provider/distro' column has no regressions, in both 'waiting' and 'active' state, for the following

  • generic imported (k3s)
  • imported AKS
  • provisioned k3s
  • provisioned AKS

@richard-cox richard-cox removed their request for review December 19, 2025 09:28
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing stale review, and going on #16213 (review) approving

@eva-vashkevich eva-vashkevich merged commit bac4bc1 into rancher:master Dec 23, 2025
62 of 63 checks passed
@eva-vashkevich eva-vashkevich deleted the iss13472 branch December 23, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Imported k3s or rke2 cluster has a strange view in Waiting state

3 participants