Skip to content

Conversation

@codyrancher
Copy link
Member

@codyrancher codyrancher commented Dec 16, 2025

Summary

fixes #16196

Technical notes summary

Providing a default eliminates the warning. In the case we provide a noop default function.

Areas or cases that should be tested

The /home page shouldn't emit the warning anymore and a defail page should still show tab counts properly.

Areas which could experience regressions

See above

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@codyrancher codyrancher added this to the v2.14.0 milestone Dec 16, 2025
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.14.0 milestone Dec 16, 2025
@codyrancher codyrancher requested a review from momesgin December 16, 2025 18:11
@codyrancher codyrancher marked this pull request as ready for review December 16, 2025 18:11
Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the warning is gone, LGTM

@codyrancher codyrancher merged commit 32ed255 into rancher:master Dec 16, 2025
86 of 94 checks passed
@codyrancher codyrancher deleted the update-count-warning branch December 16, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Console Warning: [Vue warn]: injection "update-count" not found.

2 participants