Skip to content

Conversation

@momesgin
Copy link
Member

@momesgin momesgin commented Dec 16, 2025

Summary

Fixes #15890

Occurred changes and/or fixed issues

Technical notes summary

  • Added a new method preserveCustomRegistryValue to preserve the user's values for the custom registry checkbox and its text input
  • E2E test

Areas or cases that should be tested

First intall a chart, then go back to edit it. Play with different states for the custom registry checkbox and its text input while changing the version, and make sure the value of them persists.

Areas which could experience regressions

Make sure you can change the values of different inputs during the install specially in the step that has the version or project dropdown, and the installing process is successful.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@momesgin momesgin added this to the v2.14.0 milestone Dec 16, 2025
@momesgin momesgin self-assigned this Dec 16, 2025
@momesgin momesgin requested a review from codyrancher December 19, 2025 00:58
@momesgin momesgin merged commit e739a1f into rancher:master Dec 19, 2025
64 of 66 checks passed
@momesgin momesgin deleted the 15890-chart-container-registry branch December 19, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart upgrade fails when upgrading from Installed Apps page

2 participants