Skip to content

Conversation

@yulken
Copy link
Contributor

@yulken yulken commented Dec 5, 2025

Summary

Fixes #16086

Occurred changes and/or fixed issues

Technical notes summary

The fallback scenario was failing due to an empty string

Areas or cases that should be tested

Browser used for local testing: Google Chrome
Steps to reproduce are in the attached issue.

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@rancher-max rancher-max added this to the v2.14.0 milestone Dec 5, 2025
@yulken yulken requested a review from torchiaf December 9, 2025 14:03
@richard-cox richard-cox requested a review from a110605 January 5, 2026 17:03
Copy link
Member

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing. Looks good to me.

Copy link
Contributor

@houhoucoop houhoucoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 974a0ca into rancher:master Jan 7, 2026
48 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Using one Harvester machine pool with vGPU and one without causes JSON parse errors

4 participants