Skip to content

Conversation

@codyrancher
Copy link
Member

Summary

Fixes #14545

Occurred changes and/or fixed issues

Changes how we select the default tab and adds the plumbing to allow ancestors components to provide the initial tab.

Technical notes summary

I did create a more concise version which uses inject/provide but it was requested that we use this version instead. #15686 (comment)

Areas or cases that should be tested

Places that have default tabs and the show configuration mechanism

Areas which could experience regressions

See above - All edit pages could also technically have issues.

Screenshot/Video

Screencast_20251120_110910.webm

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@codyrancher codyrancher requested a review from momesgin November 21, 2025 14:40
@codyrancher codyrancher marked this pull request as ready for review November 21, 2025 14:40
class="min-height"
:use-hash="useTabbedHash"
:default-tab="defaultTab"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity, is this our new code style to seperate event handlers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it was just autoformatting.

I'll fix it after you review the rest so I can include it with other changes.

Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks good to me, I'm just wondering if we already have some e2e tests on a page where we display this Show Configuration to add an assertion for this change too

@codyrancher codyrancher merged commit 0bc1a27 into rancher:master Nov 21, 2025
61 of 62 checks passed
@codyrancher codyrancher deleted the drawer-tab-navigation-v3 branch November 21, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resource Detail: Allow the show configuration in the metadata labels/annotations to directly open the appropriate tabs

2 participants