Skip to content

Conversation

@yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Nov 20, 2025

Summary

Fixes #rancher/qa-tasks#2053

  • Refactor repository disable/enable test to improve retry reliability.
  • Moved the failing disable/enable test into its own describe block and split it into separate it blocks: disable, refresh menu validation, and enable.
  • The repository is created once via API in the before hook, preventing duplicate creation attempts on retry and avoiding "clusterrepos.catalog.cattle.io ... already exists" errors.
  • Each test checks the current state before acting, making them idempotent and retry-safe.

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@yonasberhe23 yonasberhe23 added this to the v2.14.0 milestone Nov 20, 2025
@yonasberhe23 yonasberhe23 self-assigned this Nov 20, 2025
@yonasberhe23 yonasberhe23 marked this pull request as ready for review November 20, 2025 20:49
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 merged commit e6801c9 into rancher:master Nov 21, 2025
66 of 67 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_repositories_tests_214 branch November 21, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants