Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Nov 17, 2025

Summary

This refactors components under shell/edit/persistentvolume so that data initialization logic is no longer in the data prop.

Fixes #14864

Occurred changes and/or fixed issues

  • Refactor persistentvolume data props

Technical notes summary

Most of the changes represented in this PR fall under two buckets:

  1. Moving data props over to computed props
  2. Moving data initialization into the created hook

Areas or cases that should be tested

Persistent volumes - created/edit/delete

Areas which could experience regressions

Moving initialization code from data to the created hook can alter the component logic. Common side-effects will be exposed as components failing to render, or rendering with incorrect default data.

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@rak-phillip rak-phillip force-pushed the task/14864-persistent-volume branch from 05606e7 to 5546b29 Compare November 20, 2025 18:19
@rak-phillip rak-phillip marked this pull request as ready for review November 20, 2025 18:48
@rak-phillip
Copy link
Member Author

@mantis-toboggan-md this has been rebased on top of master and is ready for review.

Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit f7350ce into rancher:master Nov 21, 2025
33 checks passed
@rak-phillip rak-phillip deleted the task/14864-persistent-volume branch November 21, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data Exceptions: Persistent Volume

2 participants