Skip to content

Conversation

@momesgin
Copy link
Member

@momesgin momesgin commented Nov 14, 2025

Summary

Fixes #15767

Occurred changes and/or fixed issues

Improved accessibility for the "plus more" badge when there are multiple IPs.

Technical notes summary

  • Made the "plus more" selectable by keyboard
  • Made the tooltip being visible on focus
  • Added aria-label to provide better context

Areas or cases that should be tested

I had to mock multiple IPs scenario, not sure how you can find/create a real case scenario. Once you have the right scenario you should go to Explorer => Cluster => Nodes and then use keyboard to select the "plus more" badge, then hit space/enter key to open the popup, also test using keyboard to apply copy to clipboard and closing the popup.

Areas which could experience regressions

Make sure keyboard navigation is working for the rest of the elements in the table, specially the closest elements to the "plus more"

Screenshot/Video

kn.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@momesgin momesgin added this to the v2.14.0 milestone Nov 14, 2025
@momesgin momesgin self-assigned this Nov 14, 2025
@momesgin momesgin added the QA/manual-test Indicates issue requires manually testing label Nov 14, 2025
@momesgin momesgin requested a review from aalves08 November 14, 2025 20:10
@momesgin momesgin marked this pull request as ready for review November 14, 2025 20:10
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@momesgin momesgin merged commit d87982f into rancher:master Nov 19, 2025
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA/manual-test Indicates issue requires manually testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard navigation for the multiple IPs

2 participants