Skip to content

Conversation

@torchiaf
Copy link
Member

@torchiaf torchiaf commented Nov 12, 2025

Summary

Fixes #15344

Occurred changes and/or fixed issues

The UI is saving the HelmOp's downstreamResources in the wrong field

Technical notes summary

Areas or cases that should be tested

  • Fleet -> HelmOps -> Advanced step -> select ConfigMaps and Secrets

Areas which could experience regressions

Screenshot/Video

Screencast.from.2025-11-12.10-23-42.webm

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@torchiaf torchiaf requested a review from cnotv November 12, 2025 08:54
@torchiaf torchiaf added this to the v2.13.0 milestone Nov 12, 2025
@torchiaf torchiaf changed the title Fix HelmOps DownstreamResources - move from spec.helm to spec Fix HelmOps DownstreamResources - move from spec.helm to spec Nov 12, 2025
cnotv
cnotv previously approved these changes Nov 12, 2025
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf force-pushed the fleet-fix-downstream-resources branch from a603ffe to 4fb7f3f Compare November 12, 2025 12:06
@torchiaf torchiaf requested a review from cnotv November 12, 2025 12:06
cnotv
cnotv previously approved these changes Nov 12, 2025
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pipeline needs to be fixed, but for a next quicker review LGTM ✅

@torchiaf torchiaf merged commit 5239d7a into rancher:master Nov 12, 2025
59 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fleet pass secrets and config maps to workload cluster

3 participants