Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Nov 11, 2025

Summary

This makes a few changes to replace old nuxt naming conventions with ones that are more Dashboard-centric.

Occurred changes and/or fixed issues

  • Rename __nuxt to __root
  • Rename NuxtLoading component
  • Rename nuxtClientInit action to dashboardClientInit
  • Rename nuxt-client-init to dashboard-client-init

Technical notes summary

This is some additional work to remove traces of nuxt used throughout dashboard. Most of these changes are simple renames to ensure that our code is focused on Dashboard.

Areas or cases that should be tested

Dashboard should load and display the loading indicator properly. e2e tests should pass CI.

Areas which could experience regressions

I think that we should see issues in CI if there are problems with renames.

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@cnotv
Copy link
Member

cnotv commented Nov 11, 2025

I do not see any direct issue here, although there may be conflicts with other extensions.
In Kubewarden we have also Nuxt references, nothing blocking for this case as it's dead code.

Screenshot 2025-11-11 at 14 49 20

@cnotv
Copy link
Member

cnotv commented Nov 11, 2025

PR is failing for some reasons, even if the milestone is there:

Screenshot 2025-11-11 at 14 52 43

@rak-phillip
Copy link
Member Author

PR is failing for some reasons, even if the milestone is there:

@cnotv it just needed a re-run. All is good.

Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are fine with Harvester checks, I am fine with it.

@rak-phillip rak-phillip merged commit cee4f6e into rancher:master Nov 19, 2025
100 of 107 checks passed
@rak-phillip rak-phillip deleted the task/replace-nuxt-client-init branch November 19, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants