Skip to content

Conversation

@momesgin
Copy link
Member

@momesgin momesgin commented Nov 7, 2025

Summary

Fixes #15891

Occurred changes and/or fixed issues

Added an extra check for the case where you upgrade from a pre-release to a stable version.

Technical notes summary

  • Added the isUpgradeFromPreToStable function to shell/utils/version.js to detect upgrades from pre-release to stable versions.
  • Unit tests

Areas or cases that should be tested

As described in the issue's description install an older pre-release version of a chart(e.g. Kubewarden), then go to the chart's detail page and select versions above and below it and check the action button to make sure it display the correct wording, then by clicking on the action button go to the install wizard page to check the correct wording there too.

Areas which could experience regressions

  • Install an older stable version of a chart and do rest checks the same as above.
  • Some charts have versions like 108.0.0+up0.25.0-rc.4(e.g. Rancher Turtles - the Cluster API Extension) those should be tested too.

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@momesgin momesgin added this to the v2.13.0 milestone Nov 7, 2025
@momesgin momesgin self-assigned this Nov 7, 2025
@momesgin momesgin added the QA/manual-test Indicates issue requires manually testing label Nov 7, 2025
@momesgin momesgin requested a review from codyrancher November 7, 2025 19:27
@momesgin momesgin marked this pull request as ready for review November 7, 2025 19:28
@momesgin momesgin merged commit c4f2f1f into rancher:master Nov 7, 2025
60 of 62 checks passed
@momesgin momesgin deleted the 15891-prerelease-upgrade branch November 7, 2025 22:31
a110605 pushed a commit to a110605/harvester-dashboard that referenced this pull request Nov 9, 2025
a110605 pushed a commit to a110605/harvester-dashboard that referenced this pull request Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA/manual-test Indicates issue requires manually testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart upgrade from prerelease version shows incorrect "Downgrade" button text

2 participants