-
Notifications
You must be signed in to change notification settings - Fork 302
Implements RcIcon from the design system #15886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I refactored the rest of the places we use status so the code could be shared.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I placed utils inside the components library due to extensive issues with referencing imports outside of this directory via aliases or relative paths.
Depending on what you choose I ran into issues with:
- Building extensions
- Building storybook
- Running storybook
- Importing into shell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is fine as long we intend to keep these utils internal to Rancher Components.
rak-phillip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments. I think the only item that we really need to address is the type casting.
I think this looks excellent and I hope that it will help to make our icon usage more consistent across the board.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is fine as long we intend to keep these utils internal to Rancher Components.
rak-phillip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Implements the RcIcon component of our Design System.
Technical notes summary
I did some refactoring so that our status color/design could more easily be reused.
Areas or cases that should be tested
The storybook for RcIcon, RcStatusBadge and RcStatusIndicator.
Areas which could experience regressions
See above
Screenshot/Video
Checklist
Admin,Standard UserandUser Base