Skip to content

Conversation

@codyrancher
Copy link
Member

@codyrancher codyrancher commented Nov 6, 2025

Summary

Implements the RcIcon component of our Design System.

Technical notes summary

I did some refactoring so that our status color/design could more easily be reused.

Areas or cases that should be tested

The storybook for RcIcon, RcStatusBadge and RcStatusIndicator.

Areas which could experience regressions

See above

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@codyrancher codyrancher changed the title Rc icon Implements RcIcon from the design system Nov 20, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I placed utils inside the components library due to extensive issues with referencing imports outside of this directory via aliases or relative paths.
Depending on what you choose I ran into issues with:

  • Building extensions
  • Building storybook
  • Running storybook
  • Importing into shell

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is fine as long we intend to keep these utils internal to Rancher Components.

@codyrancher codyrancher marked this pull request as ready for review November 20, 2025 02:33
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. I think the only item that we really need to address is the type casting.

I think this looks excellent and I hope that it will help to make our icon usage more consistent across the board.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is fine as long we intend to keep these utils internal to Rancher Components.

Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyrancher codyrancher merged commit b5a1f22 into rancher:master Nov 21, 2025
36 checks passed
@codyrancher codyrancher deleted the rc-icon branch November 21, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants