Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Nov 3, 2025

Summary

This reintroduces that original !currentCluster condition for displaying the Rancher logo.

Fixes #15673

Occurred changes and/or fixed issues

  • Reintroduce !currentCluster for logo render condition

Technical notes summary

The original PR replaced !currentCluster with a route test because currentCluster can be set to undefined. Introducing the condition for current cluster will allow for maintaining current behavior, with the added benefit of eliminating the "flashing" behavior with the route check.

Areas or cases that should be tested

Navigating between routes in dashboard.

Imported Harvester clusters.

Areas which could experience regressions

Same as to test - the logo needs to render consistently.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@rak-phillip rak-phillip self-assigned this Nov 3, 2025
@rak-phillip rak-phillip added this to the v2.13.0 milestone Nov 3, 2025
@rak-phillip rak-phillip merged commit b7fd11a into rancher:master Nov 3, 2025
81 of 92 checks passed
@rak-phillip rak-phillip deleted the bugfix/15673-logo-flash-regression branch November 3, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rancher logo "flashes" when navigating betwen pages

2 participants