Skip to content

Automation: fix fleet cluster workspace change test #15839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yonasberhe23 merged 1 commit into from
Nov 4, 2025
Merged

Automation: fix fleet cluster workspace change test #15839

yonasberhe23 merged 1 commit into from
Nov 4, 2025

Conversation

@yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Nov 3, 2025 •
edited
Loading

Summary

Fixes #rancher/qa-tasks#1980

  • Added loading indicator check to ensure page is fully loaded
  • Improved workspace change test with proper intercepts and cluster ID fetching
  • Added getKubernetesReleases Cypress command to fetch Kubernetes releases from the API

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@yonasberhe23 yonasberhe23 added this to the v2.13.0 milestone Nov 3, 2025
@yonasberhe23 yonasberhe23 self-assigned this Nov 3, 2025
@yonasberhe23 yonasberhe23 changed the title fix fleet cluster workspace change test Automation: fix fleet cluster workspace change test Nov 3, 2025
@yonasberhe23 yonasberhe23 marked this pull request as draft November 3, 2025 19:01
@yonasberhe23 yonasberhe23 force-pushed the fix_fleet_cluster_workspace_change_test_2.13 branch 2 times, most recently from 767e768 to d4a68f6 Compare November 3, 2025 21:41
@yonasberhe23 yonasberhe23 force-pushed the fix_fleet_cluster_workspace_change_test_2.13 branch from d4a68f6 to c500097 Compare November 3, 2025 22:11
@yonasberhe23 yonasberhe23 marked this pull request as ready for review November 4, 2025 00:01
izaac
izaac approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good improvements here. Removing the hardcoded kubeversion is a very good call. :shipit:

cypress/support/commands/rancher-api-commands.ts
enabled: false,
caCerts: '',
fqdn: ''
kubernetesVersion,
Copy link
Contributor

@izaac izaac Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change! 👍🏽

@yonasberhe23 yonasberhe23 merged commit b289d06 into rancher:master Nov 4, 2025
39 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_fleet_cluster_workspace_change_test_2.13 branch November 4, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@izaac izaac izaac approved these changes

@a-arias a-arias Awaiting requested review from a-arias

@IsaSih IsaSih Awaiting requested review from IsaSih

Assignees

@yonasberhe23 yonasberhe23

Labels

area/e2e QA/None

Projects

None yet

Milestone

v2.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@yonasberhe23 @izaac