Skip to content

Conversation

@yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Oct 31, 2025

Summary

Fixes #rancher/qa-tasks#2043

Problem
A e2e test (cypress/e2e/tests/pages/fleet/fleet-clusters.spec.ts) creates an AWS cloud credential during setup but doesn't clean it up, leaving orphaned credentials that can affect subsequent test runs.

Solution

  • Track the cloud credential ID created during cluster setup and delete it in the after hook cleanup.
  • As fallback, clean up any orphaned Amazon cloud credentials before test execution in cloud-credential.spec.ts

Screenshot/Video

Screenshot 2025-10-31 at 10 42 34 AM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@yonasberhe23 yonasberhe23 force-pushed the fix_cloud_cred_test_2.13 branch from 504b7af to 58945a6 Compare October 31, 2025 17:35
Copy link
Contributor

@a-arias a-arias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and no errors found.

@yonasberhe23 yonasberhe23 merged commit 44ce1f5 into rancher:master Oct 31, 2025
62 of 64 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_cloud_cred_test_2.13 branch October 31, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants