Use scoped style for banner graphic #15823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15822
Occurred changes and/or fixed issues
The BannerGraphic styles don't need to be global - this PR changes them to
scoped- they are only used in this component.We rename the top-level style (adding
-area) so that any extensions built with older shell will not interfere going forward.We also use a CSS var for the banner height to avoid issues with CSS specitivity.
Areas or cases that should be tested
Check the home page banner graphic appears correctly with the suse and modern brands/themes.
Bonus points - install the Harvester extension and check that the home page banner when
ui-brandis set tosuseis unaffected.Things that are broken to validate, when the brand is
suseand the Harvester UI Extension is loaded:Checklist
Admin,Standard UserandUser Base