Skip to content

Conversation

@nwmac
Copy link
Member

@nwmac nwmac commented Oct 31, 2025

Summary

Fixes #15822

Occurred changes and/or fixed issues

The BannerGraphic styles don't need to be global - this PR changes them to scoped - they are only used in this component.

We rename the top-level style (adding -area) so that any extensions built with older shell will not interfere going forward.

We also use a CSS var for the banner height to avoid issues with CSS specitivity.

Areas or cases that should be tested

Check the home page banner graphic appears correctly with the suse and modern brands/themes.

Bonus points - install the Harvester extension and check that the home page banner when ui-brand is set to suse is unaffected.

Things that are broken to validate, when the brand is suse and the Harvester UI Extension is loaded:

  • The banner height becomes 200px and not 160px
  • The banner text gets a 20px margin instead of 0 margin - so the text does not appear vertically centred in the banner

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 1d65f06 into rancher:master Oct 31, 2025
61 of 63 checks passed
@nwmac nwmac deleted the scope-styles-for-banner branch October 31, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harvester Extension overwrites BannerGraphic styles

2 participants