Skip to content

Conversation

@mantis-toboggan-md
Copy link
Member

Summary

Fixes #15538

Technical notes summary

This is the line throwing the error

    async saveRoleBindings() {
      await this.value.waitForMgmt();

      if (this.membershipUpdate.save) {
        await this.membershipUpdate.save(this.value.mgmt.id); <------ this.value.mgmt is undefined here
      }
    },

My own local testing and console logs in the issue's screenshot confirm that the wait for management ended because management was found; it didn't time out. The issue appears to be that for a brief window after a provisioning cluster is created, the model's this doesn't include updated status so we can't get the management cluster's id. There is already a workaround for this in waitForMgmt. I added the same workaround to the mgmtId getter

Areas or cases that should be tested

The scenario as described in the issue should be tested. Note for my fellow firefox enjoyers: it seems specific to chrome

Areas which could experience regressions

none

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@mantis-toboggan-md mantis-toboggan-md merged commit 9fc2d76 into rancher:master Oct 30, 2025
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error custom cluster creation - cannot read properties of undefined (reading "id")

2 participants