Skip to content

Merge the same cloudInit userdata and networkdata into same option when creating harvester downstream cluster #15760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a110605 merged 3 commits into from
Oct 30, 2025
Merged

Merge the same cloudInit userdata and networkdata into same option when creating harvester downstream cluster #15760

a110605 merged 3 commits into from
Oct 30, 2025

Conversation

@a110605
Copy link
Member

@a110605 a110605 commented Oct 28, 2025

Summary

Fixes #
harvester/harvester#7778

Occurred changes and/or fixed issues

harvester/harvester#7778 (comment)

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

fixed.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@a110605 a110605 added this to the v2.13.0 milestone Oct 28, 2025
@a110605 a110605 self-assigned this Oct 28, 2025
@a110605 a110605 mentioned this pull request Oct 28, 2025
Closed
@a110605 a110605 changed the title Merge the same cloudInit userdata and network into same option when creating harvester downstream cluster Merge the same cloudInit userdata and networkdata into same option when creating harvester downstream cluster Oct 28, 2025
houhoucoop
houhoucoop reviewed Oct 28, 2025
View reviewed changes
@a110605 a110605 requested a review from houhoucoop October 29, 2025 07:57
houhoucoop
houhoucoop reviewed Oct 29, 2025
View reviewed changes
houhoucoop
houhoucoop previously approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@houhoucoop houhoucoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

houhoucoop
houhoucoop approved these changes Oct 30, 2025
View reviewed changes
Copy link
Contributor

@houhoucoop houhoucoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 5173e8f into rancher:master Oct 30, 2025
33 checks passed
@irishgordo irishgordo mentioned this pull request Nov 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houhoucoop houhoucoop houhoucoop approved these changes

@torchiaf torchiaf Awaiting requested review from torchiaf

Assignees

@a110605 a110605

Labels

QA/None

Projects

None yet

Milestone

v2.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@a110605 @houhoucoop