Fixing view yaml in general and specifically in the case of provisioning clusters #15756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyrancher
commented
Oct 28, 2025
| }, | ||
| isFullPageOverride() { | ||
| return this.isView && this.value.fullDetailPageOverride; | ||
| return this.isView && this.value.fullDetailPageOverride && !this.isYaml; |
Member
Author
There was a problem hiding this comment.
This fixes the issue where we would display a blank page for view yaml
codyrancher
commented
Oct 28, 2025
Comment on lines
-263
to
-282
| goToViewYaml() { | ||
| let location; | ||
|
|
||
| if ( !this.isRke2 ) { | ||
| location = this.mgmt?.detailLocation; | ||
| } | ||
|
|
||
| if ( !location ) { | ||
| location = this.detailLocation; | ||
| } | ||
|
|
||
| location.query = { | ||
| ...location.query, | ||
| [MODE]: _VIEW, | ||
| [AS]: _YAML | ||
| }; | ||
|
|
||
| this.currentRouter().push(location); | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
This may feel risky but the reason I was comfortable taking this approach was because we don't override the edit yaml or download yaml location for this model. By removing this we're making things more consistent.
That's not to say that there isn't some unknown risk though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15736
Occurred changes and/or fixed issues
There were actually two problems that got fixed here.
Areas or cases that should be tested
Viewing, editing and downloading yaml for each cluster provider type.
To make
View Yamlvisible you should login to a standard user that has been made a cluster member to the cluster you wish to invokeView Yamlon.Areas which could experience regressions
See above
Screenshot/Video
wrong-yaml.mp4
Checklist
Admin,Standard UserandUser Base