Skip to content

Automation: fix logging chart test #15753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yonasberhe23 merged 1 commit into from
Oct 28, 2025
Merged

Automation: fix logging chart test #15753

yonasberhe23 merged 1 commit into from
Oct 28, 2025

Conversation

@yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Oct 27, 2025 •
edited
Loading

Summary

Fixes #

Fixes flaky logging test.

  • Added a visibility check for the installed apps list container before proceeding with sortable table operations. This ensures that the [data-testid="installed-app-catalog-list"] element is present and visible before the test attempts to interact with its child elements (the sortable table).
  • Also added a check to ensure the prompt remove dialog is no longer visible after the uninstall operation.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@yonasberhe23 yonasberhe23 added this to the v2.13.0 milestone Oct 27, 2025
@yonasberhe23 yonasberhe23 self-assigned this Oct 27, 2025
@yonasberhe23 yonasberhe23 force-pushed the fix_logging_chart_test branch 3 times, most recently from 7d7c448 to 6a226c8 Compare October 27, 2025 21:05
@yonasberhe23 yonasberhe23 marked this pull request as ready for review October 27, 2025 21:07
@yonasberhe23 yonasberhe23 force-pushed the fix_logging_chart_test branch from 6a226c8 to a35e0a1 Compare October 27, 2025 21:08
eva-vashkevich
eva-vashkevich previously approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yonasberhe23 yonasberhe23 force-pushed the fix_logging_chart_test branch from a35e0a1 to edfd4e4 Compare October 27, 2025 22:24
eva-vashkevich
eva-vashkevich approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. i think

izaac
izaac reviewed Oct 27, 2025
View reviewed changes
cypress/e2e/po/components/kubectl.po.ts

waitForTerminalStatus(status: 'Connected' | 'Disconnected', options?: GetOptions) {
this.self().find('.active .status').contains(status, options).should('be.visible');
this.self().contains('.active .status', status, options);
Copy link
Contributor

@izaac izaac Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are other charts installs look after this change on Jenkins?

Copy link
Contributor Author

@yonasberhe23 yonasberhe23 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all passing with this change

Image

@yonasberhe23 yonasberhe23 merged commit 6ff4679 into rancher:master Oct 28, 2025
194 of 201 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_logging_chart_test branch October 28, 2025 03:19
@yonasberhe23 yonasberhe23 mentioned this pull request Oct 28, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@izaac izaac izaac left review comments

@eva-vashkevich eva-vashkevich eva-vashkevich approved these changes

Assignees

@yonasberhe23 yonasberhe23

Labels

area/e2e QA/None

Projects

None yet

Milestone

v2.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yonasberhe23 @izaac @eva-vashkevich