Skip to content

Conversation

@torchiaf
Copy link
Member

@torchiaf torchiaf commented Oct 27, 2025

Summary

Occurred changes and/or fixed issues

Technical notes summary

  • Replacing errors with console warn messages in ui-context directive
  • Adding the context for Header's status banners, in the Details pages.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@torchiaf torchiaf added this to the v2.13.0 milestone Oct 27, 2025
@torchiaf torchiaf requested a review from rak-phillip October 27, 2025 16:53
@torchiaf torchiaf force-pushed the fix-ui-context branch 3 times, most recently from fc9ac14 to fe9452e Compare October 28, 2025 18:39
Comment on lines 15 to 18
export interface Props {
value?: Object;
resourceSubtype?: string;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to keep the props interface export outside of script setup so that existing imports don't break. See example usage in https://vuejs.org/api/sfc-script-setup.html#usage-alongside-normal-script

Copy link
Member Author

@torchiaf torchiaf Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this change was unintentional, probably something went wrong during a rebase. It was the eslint moving the code from first to second script.
Now it's fixed

…o avoid unwanted exports moving

Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf changed the title Replace errors with console warn messages in ui-context directive Add ui-context in Header's status banners Oct 28, 2025
@torchiaf torchiaf merged commit 0f2e9c9 into rancher:master Oct 29, 2025
62 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants