-
Notifications
You must be signed in to change notification settings - Fork 302
Add ui-context in Header's status banners #15752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Francesco Torchia <[email protected]>
fc9ac14 to
fe9452e
Compare
| export interface Props { | ||
| value?: Object; | ||
| resourceSubtype?: string; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to keep the props interface export outside of script setup so that existing imports don't break. See example usage in https://vuejs.org/api/sfc-script-setup.html#usage-alongside-normal-script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this change was unintentional, probably something went wrong during a rebase. It was the eslint moving the code from first to second script.
Now it's fixed
Signed-off-by: Francesco Torchia <[email protected]>
fe9452e to
afd8f14
Compare
…o avoid unwanted exports moving Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
afd8f14 to
ce4eabd
Compare
rak-phillip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist
Admin,Standard UserandUser Base