Skip to content

Conversation

@aalves08
Copy link
Member

Summary

Fixes #15710

Occurred changes and/or fixed issues

  • fix problem with Kubewarden chart upgrade
  • update unit test

Technical notes summary

Areas or cases that should be tested

1) Direct usecase for issue (problem upgrading KW chart):

  • Add kubewarden repository in local - Apps - Repositories of type http and url https://charts.kubewarden.io
  • Go To Apps - Repositories, search for Kubewarden and install the chart
  • Verify that kubewarden-controller version 5.7.0 and kubewarden-crds version 1.21.0 are installed
  • Go to "Preferences" -> Helm Chart -> "Include Prerelease Versions"
  • Go To Apps - Repositories, search for Kubewarden and click to upgrade the chart (should be upgrading to 5.8.0-rc1)
  • Verify that upgrade succeeded

2) Test general chart install
3) Test general chart upgrade

Areas which could experience regressions

  • installing/upgrading charts

Screenshot/Video

Screen.Recording.2025-10-27.at.13.30.57.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@aalves08 aalves08 added this to the v2.13.0 milestone Oct 27, 2025
@aalves08 aalves08 self-assigned this Oct 27, 2025
Copy link
Member

@codyrancher codyrancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with your suggestion around adding an extra argument to the diff method to determine if we use the new method.

By doing this it will reduce the risk without complicating much. I don't want to end up with a duplicate method unless we also plan to dig into this further and deprecate it.

I believe this null is related to the fact that there are times if we want to save a resource and delete a field we have to specify that field as null to delete because if it's set to undefined it will do nothing. I don't fully recall where this has occurred though.

@aalves08 aalves08 requested a review from codyrancher October 28, 2025 09:23
@aalves08 aalves08 merged commit 468bdc1 into rancher:master Oct 28, 2025
60 of 62 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 29, 2025
* fix problem with Kubewarden chart upgrade + update unit test

* update

* update unit test

* update pr based on comment

* fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade is missing new value field

2 participants